2018-12-02 12:07:27

by Hauke Mehrtens

Subject: [PATCH] mt76: Add missing include of linux/module.h

MODULE_FIRMWARE() is used in usb_mcu.c and provided by linux/module.h,
but this header file is not directly included. This causes problems in
backports with some kernel versions.

Add the missing include.

Signed-off-by: Hauke Mehrtens <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt76x0/usb_mcu.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76x0/usb_mcu.c
index a9f14d5149d1..b2b3fd0db4bb 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb_mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb_mcu.c
@@ -15,6 +15,7 @@
*/
#include <linux/kernel.h>
#include <linux/firmware.h>
+#include <linux/module.h>

#include "mt76x0.h"
#include "mcu.h"
--
2.11.0

2018-12-28 12:20:14

by Felix Fietkau

Subject: Re: [PATCH] mt76: Add missing include of linux/module.h

On 2018-12-02 13:06, Hauke Mehrtens wrote:
> MODULE_FIRMWARE() is used in usb_mcu.c and provided by linux/module.h,
> but this header file is not directly included. This causes problems in
> backports with some kernel versions.
>
> Add the missing include.
>
> Signed-off-by: Hauke Mehrtens <[email protected]>

Applied, thanks.

- Felix