2023-03-08 17:47:25

by Pradeep Kumar Chitrapu

[permalink] [raw]
Subject: [PATCH 2/2] wifi: ath11k: Fix incorrect update of BCC counters in peer stats

Fix typos causing incorrect update of BCC counters in 11ax mode.

Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01725-QCAHKSWPL_SILICONZ-1

Signed-off-by: Pradeep Kumar Chitrapu <[email protected]>
---
drivers/net/wireless/ath/ath11k/hal_rx.c | 4 ++--
drivers/net/wireless/ath/ath11k/hal_rx.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/hal_rx.c b/drivers/net/wireless/ath/ath11k/hal_rx.c
index 7f39c6fb7408..d462b36c3cb2 100644
--- a/drivers/net/wireless/ath/ath11k/hal_rx.c
+++ b/drivers/net/wireless/ath/ath11k/hal_rx.c
@@ -1023,7 +1023,7 @@ ath11k_hal_rx_parse_mon_status_tlv(struct ath11k_base *ab,
info1 = __le32_to_cpu(vht_sig->info1);

ppdu_info->ldpc = FIELD_GET(HAL_RX_VHT_SIG_A_INFO_INFO1_SU_MU_CODING,
- info0);
+ info1);
ppdu_info->mcs = FIELD_GET(HAL_RX_VHT_SIG_A_INFO_INFO1_MCS,
info1);
gi_setting = FIELD_GET(HAL_RX_VHT_SIG_A_INFO_INFO1_GI_SETTING,
@@ -1446,7 +1446,7 @@ ath11k_hal_rx_parse_mon_status_tlv(struct ath11k_base *ab,
* PHYRX_OTHER_RECEIVE_INFO TLV.
*/
ppdu_info->rssi_comb =
- FIELD_GET(HAL_RX_PHYRX_RSSI_LEGACY_INFO_INFO1_RSSI_COMB,
+ FIELD_GET(HAL_RX_PHYRX_RSSI_LEGACY_INFO_INFO0_RSSI_COMB,
__le32_to_cpu(rssi->info0));

if (db2dbm) {
diff --git a/drivers/net/wireless/ath/ath11k/hal_rx.h b/drivers/net/wireless/ath/ath11k/hal_rx.h
index f6bae07abfd3..064796935f9c 100644
--- a/drivers/net/wireless/ath/ath11k/hal_rx.h
+++ b/drivers/net/wireless/ath/ath11k/hal_rx.h
@@ -385,7 +385,7 @@ struct hal_rx_he_sig_b2_ofdma_info {
__le32 info0;
} __packed;

-#define HAL_RX_PHYRX_RSSI_LEGACY_INFO_INFO1_RSSI_COMB GENMASK(15, 8)
+#define HAL_RX_PHYRX_RSSI_LEGACY_INFO_INFO0_RSSI_COMB GENMASK(15, 8)

#define HAL_RX_PHYRX_RSSI_PREAMBLE_PRI20 GENMASK(7, 0)

--
2.17.1



Subject: Re: [PATCH 2/2] wifi: ath11k: Fix incorrect update of BCC counters in peer stats



On 3/8/2023 11:17 PM, Pradeep Kumar Chitrapu wrote:
> Fix typos causing incorrect update of BCC counters in 11ax mode.

Not sure all these will come under typos. They seem to be bugs no?

Vasanth

2023-03-15 10:27:29

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH 2/2] wifi: ath11k: Fix incorrect update of BCC counters in peer stats

Pradeep Kumar Chitrapu <[email protected]> writes:

> Fix typos causing incorrect update of BCC counters in 11ax mode.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01725-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Pradeep Kumar Chitrapu <[email protected]>

What are BCC counters?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2023-03-15 16:14:26

by Pradeep Kumar Chitrapu

[permalink] [raw]
Subject: Re: [PATCH 2/2] wifi: ath11k: Fix incorrect update of BCC counters in peer stats


On 3/15/2023 3:27 AM, Kalle Valo wrote:
> Pradeep Kumar Chitrapu <[email protected]> writes:
>
>> Fix typos causing incorrect update of BCC counters in 11ax mode.
>>
>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01725-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Pradeep Kumar Chitrapu <[email protected]>
> What are BCC counters?
Thanks Kalle and Vasanth for review..will address the comments in next
revision.