2023-01-11 11:29:57

by Arend Van Spriel

[permalink] [raw]
Subject: [PATCH V2] wifi: brcmfmac: fix regression for Broadcom PCIe wifi devices

Attachments:
(No filename) (1.36 kB)
 smime.p7s (4.12 kB)
S/MIME Cryptographic Signature Download all attachments

2023-01-11 11:42:44

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH V2] wifi: brcmfmac: fix regression for Broadcom PCIe wifi devices

On 1/11/2023 12:24 PM, Arend van Spriel wrote:
> A sanity check was introduced considering maximum flowrings above
> 256 as insane and effectively aborting the device probe. This
> resulted in regression for number of users as the value turns out
> to be sane after all.

Forgot tha mention this is for 6.2 kernel. Apparently the commit causing
the regression was also applied to 6.1 stable tree. So this should go to
stable as well.

> Fixes: 2aca4f3734bd ("brcmfmac: return error when getting invalid max_flowrings from dongle")
> Reported-by: chainofflowers <[email protected]>
> Link: https://lore.kernel.org/all/4781984.GXAFRqVoOG@luna/
> Reported-by: Christian Marillat <[email protected]>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216894
> Signed-off-by: Arend van Spriel <[email protected]>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> index ae57a9a3ab05..b67f6d0810b6 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
> @@ -1228,7 +1228,7 @@ static int brcmf_pcie_init_ringbuffers(struct brcmf_pciedev_info *devinfo)
> BRCMF_NROF_H2D_COMMON_MSGRINGS;
> max_completionrings = BRCMF_NROF_D2H_COMMON_MSGRINGS;
> }
> - if (max_flowrings > 256) {
> + if (max_flowrings > 512) {
> brcmf_err(bus, "invalid max_flowrings(%d)\n", max_flowrings);
> return -EIO;
> }

Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature

2023-01-12 09:50:01

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH V2] wifi: brcmfmac: fix regression for Broadcom PCIe wifi devices

Arend van Spriel <[email protected]> writes:

> On 1/11/2023 12:24 PM, Arend van Spriel wrote:
>> A sanity check was introduced considering maximum flowrings above
>> 256 as insane and effectively aborting the device probe. This
>> resulted in regression for number of users as the value turns out
>> to be sane after all.
>
> Forgot tha mention this is for 6.2 kernel. Apparently the commit
> causing the regression was also applied to 6.1 stable tree. So this
> should go to stable as well.

Ok, I'll add cc stable.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2023-01-16 11:37:59

by Kalle Valo

[permalink] [raw]
Subject: Re: [V2] wifi: brcmfmac: fix regression for Broadcom PCIe wifi devices

Arend van Spriel <[email protected]> wrote:

> A sanity check was introduced considering maximum flowrings above
> 256 as insane and effectively aborting the device probe. This
> resulted in regression for number of users as the value turns out
> to be sane after all.
>
> Fixes: 2aca4f3734bd ("brcmfmac: return error when getting invalid max_flowrings from dongle")
> Reported-by: chainofflowers <[email protected]>
> Link: https://lore.kernel.org/all/4781984.GXAFRqVoOG@luna/
> Reported-by: Christian Marillat <[email protected]>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216894
> Cc: [email protected]
> Signed-off-by: Arend van Spriel <[email protected]>

Patch applied to wireless.git, thanks.

ed05cb177ae5 wifi: brcmfmac: fix regression for Broadcom PCIe wifi devices

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches