2020-03-19 14:20:34

by Jes Sorensen

[permalink] [raw]
Subject: Re: [PATCH] rtl8xxxu: Fix sparse warning: cast from restricted __le16

On 3/19/20 2:43 AM, Chris Chiu wrote:
> Fix the warning reported by sparse as:
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4819:17: sparse: sparse: cast from restricted __le16
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4892:17: sparse: sparse: cast from restricted __le16
>
> Signed-off-by: Chris Chiu <[email protected]>
> Reported-by: kbuild test robot <[email protected]>

Acked-by: Jes Sorensen <[email protected]>


> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index 54a1a4ea107b..daa6ce14c68b 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -4816,8 +4816,8 @@ rtl8xxxu_fill_txdesc_v1(struct ieee80211_hw *hw, struct ieee80211_hdr *hdr,
> rate = tx_rate->hw_value;
>
> if (rtl8xxxu_debug & RTL8XXXU_DEBUG_TX)
> - dev_info(dev, "%s: TX rate: %d, pkt size %d\n",
> - __func__, rate, cpu_to_le16(tx_desc->pkt_size));
> + dev_info(dev, "%s: TX rate: %d, pkt size %u\n",
> + __func__, rate, le16_to_cpu(tx_desc->pkt_size));
>
> seq_number = IEEE80211_SEQ_TO_SN(le16_to_cpu(hdr->seq_ctrl));
>
> @@ -4889,8 +4889,8 @@ rtl8xxxu_fill_txdesc_v2(struct ieee80211_hw *hw, struct ieee80211_hdr *hdr,
> rate = tx_rate->hw_value;
>
> if (rtl8xxxu_debug & RTL8XXXU_DEBUG_TX)
> - dev_info(dev, "%s: TX rate: %d, pkt size %d\n",
> - __func__, rate, cpu_to_le16(tx_desc40->pkt_size));
> + dev_info(dev, "%s: TX rate: %d, pkt size %u\n",
> + __func__, rate, le16_to_cpu(tx_desc40->pkt_size));
>
> seq_number = IEEE80211_SEQ_TO_SN(le16_to_cpu(hdr->seq_ctrl));
>
>