2023-08-07 01:52:09

by Ping-Ke Shih

[permalink] [raw]
Subject: RE: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator



> -----Original Message-----
> From: Ruan Jinjie <[email protected]>
> Sent: Friday, August 4, 2023 11:54 AM
> To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator
>
> There is a ternary operator, the true or false judgement
> of which is unnecessary in C language semantics.
>
> Signed-off-by: Ruan Jinjie <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx4/port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c
> index 256a06b3c096..1c289488d050 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/port.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/port.c
> @@ -176,7 +176,7 @@ static bool mlx4_need_mf_bond(struct mlx4_dev *dev)
> mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH)
> ++num_eth_ports;
>
> - return (num_eth_ports == 2) ? true : false;
> + return num_eth_ports == 2;

It should be one space between '=' and '2'.

> }
>
> int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac)
> --
> 2.34.1
>
>
> ------Please consider the environment before printing this e-mail.