2010-04-03 11:51:08

by Luis Correia

Subject: [PATCH V4] rt2x00: remove MCU requests for SoC platforms

The ralink SoC platforms do not have an MCU.

Signed-off-by: Luis Correia <[email protected]>
---

Removed flag usage as per Gertjan suggestion.

diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c
b/drivers/net/wireless/rt2x00/rt2800pci.c
index ce7e88e..1df2d44 100644
--- a/drivers/net/wireless/rt2x00/rt2800pci.c
+++ b/drivers/net/wireless/rt2x00/rt2800pci.c
@@ -60,6 +60,12 @@ static void rt2800pci_mcu_status(struct rt2x00_dev
*rt2x00dev, const u8 token)
? ? ? ?unsigned int i;
? ? ? ?u32 reg;

+ ? ? ? /*
+ ? ? ? ?* SOC devices don't support MCU requests.
+ ? ? ? ?*/
+ ? ? ? if (rt2x00_is_soc(rt2x00dev))
+ ? ? ? ? ? ? ? return;
+
? ? ? ?for (i = 0; i < 200; i++) {
? ? ? ? ? ? ? ?rt2800_register_read(rt2x00dev, H2M_MAILBOX_CID, &reg);

2010-04-06 20:45:14

by John W. Linville

Subject: Re: [PATCH V4] rt2x00: remove MCU requests for SoC platforms

On Sat, Apr 03, 2010 at 04:08:44PM +0200, Gertjan van Wingerde wrote:
> On 04/03/10 15:43, Gertjan van Wingerde wrote:
> > On 04/03/10 13:49, Luis Correia wrote:
> >> The ralink SoC platforms do not have an MCU.
> >>
> >> Signed-off-by: Luis Correia <[email protected]>
> >
> > Acked-by: Gertjan van Wingerde <[email protected]>

> This patch seems to be word-wrapped and white-space damaged. I fixed it up
> and applied it to my tree.
>
> If you want you can pull from git://git.gwingerde.nl/rt2x00-next-2.6 to
> get the fixed up patch.

Thanks!

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2010-04-03 11:55:43

by Ivo Van Doorn

Subject: Re: [PATCH V4] rt2x00: remove MCU requests for SoC platforms

On Saturday 03 April 2010, Luis Correia wrote:
> The ralink SoC platforms do not have an MCU.
>
> Signed-off-by: Luis Correia <[email protected]>

Acked-by: Ivo van Doorn <[email protected]>

> ---
>
> Removed flag usage as per Gertjan suggestion.
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c
> b/drivers/net/wireless/rt2x00/rt2800pci.c
> index ce7e88e..1df2d44 100644
> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
> @@ -60,6 +60,12 @@ static void rt2800pci_mcu_status(struct rt2x00_dev
> *rt2x00dev, const u8 token)
> ? ? ? ?unsigned int i;
> ? ? ? ?u32 reg;
>
> + ? ? ? /*
> + ? ? ? ?* SOC devices don't support MCU requests.
> + ? ? ? ?*/
> + ? ? ? if (rt2x00_is_soc(rt2x00dev))
> + ? ? ? ? ? ? ? return;
> +
> ? ? ? ?for (i = 0; i < 200; i++) {
> ? ? ? ? ? ? ? ?rt2800_register_read(rt2x00dev, H2M_MAILBOX_CID, &reg);
>

2010-04-03 14:08:51

by Gertjan van Wingerde

Subject: Re: [PATCH V4] rt2x00: remove MCU requests for SoC platforms

On 04/03/10 15:43, Gertjan van Wingerde wrote:
> On 04/03/10 13:49, Luis Correia wrote:
>> The ralink SoC platforms do not have an MCU.
>>
>> Signed-off-by: Luis Correia <[email protected]>
>
> Acked-by: Gertjan van Wingerde <[email protected]>
>
>> ---
>>
>> Removed flag usage as per Gertjan suggestion.
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c
>> b/drivers/net/wireless/rt2x00/rt2800pci.c
>> index ce7e88e..1df2d44 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
>> @@ -60,6 +60,12 @@ static void rt2800pci_mcu_status(struct rt2x00_dev
>> *rt2x00dev, const u8 token)
>> unsigned int i;
>> u32 reg;
>>
>> + /*
>> + * SOC devices don't support MCU requests.
>> + */
>> + if (rt2x00_is_soc(rt2x00dev))
>> + return;
>> +
>> for (i = 0; i < 200; i++) {
>> rt2800_register_read(rt2x00dev, H2M_MAILBOX_CID, &reg);
>>

John,

This patch seems to be word-wrapped and white-space damaged. I fixed it up
and applied it to my tree.

If you want you can pull from git://git.gwingerde.nl/rt2x00-next-2.6 to
get the fixed up patch.

---
Gertjan.

2010-04-03 13:43:11

by Gertjan van Wingerde

Subject: Re: [PATCH V4] rt2x00: remove MCU requests for SoC platforms

On 04/03/10 13:49, Luis Correia wrote:
> The ralink SoC platforms do not have an MCU.
>
> Signed-off-by: Luis Correia <[email protected]>

Acked-by: Gertjan van Wingerde <[email protected]>

> ---
>
> Removed flag usage as per Gertjan suggestion.
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c
> b/drivers/net/wireless/rt2x00/rt2800pci.c
> index ce7e88e..1df2d44 100644
> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
> @@ -60,6 +60,12 @@ static void rt2800pci_mcu_status(struct rt2x00_dev
> *rt2x00dev, const u8 token)
> unsigned int i;
> u32 reg;
>
> + /*
> + * SOC devices don't support MCU requests.
> + */
> + if (rt2x00_is_soc(rt2x00dev))
> + return;
> +
> for (i = 0; i < 200; i++) {
> rt2800_register_read(rt2x00dev, H2M_MAILBOX_CID, &reg);
>