2021-01-12 13:02:59

by Kalle Valo

[permalink] [raw]
Subject: Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

(adding luca)

Michal Kubecek <[email protected]> writes:

> FYI, there is a regression in iwlwifi driver caused by commit
> ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory")
> reported at
>
> https://bugzilla.kernel.org/show_bug.cgi?id=210733
> https://bugzilla.suse.com/show_bug.cgi?id=1180344
>
> The problem seems to be an attempt to write terminating null character
> into a string which may be read only. There is also a proposed fix.

Can someone submit a proper patch, please? See instructions below how to
submit.

And please add Fixes tag to the commit log:

Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory")

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


2021-01-12 13:08:53

by Takashi Iwai

[permalink] [raw]
Subject: Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254)

On Tue, 12 Jan 2021 12:33:14 +0100,
Kalle Valo wrote:
>
> (adding luca)
>
> Michal Kubecek <[email protected]> writes:
>
> > FYI, there is a regression in iwlwifi driver caused by commit
> > ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory")
> > reported at
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=210733
> > https://bugzilla.suse.com/show_bug.cgi?id=1180344
> >
> > The problem seems to be an attempt to write terminating null character
> > into a string which may be read only. There is also a proposed fix.
>
> Can someone submit a proper patch, please? See instructions below how to
> submit.
>
> And please add Fixes tag to the commit log:
>
> Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory")

OK, I'll do it for my own, but really I hoped that someone would have
reacted on the bugzilla report before the official patch submission.
So far no one from the upstream devs showed interest in the bug at
all, unfortunately.


thanks,

Takashi