Subject: [PATCH] staging: rtl8723au: remove redundant initialization

The variable pHalData is initialized twice in this same function with
same value.So removing one of them.

Signed-off-by: Hari Prasath Gujulan Elango <[email protected]>
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
index 11e1108..9733aa6 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_cmd.c
@@ -55,7 +55,7 @@ int FillH2CCmd(struct rtw_adapter *padapter, u8 ElementID, u32 CmdLen,
u8 h2c_box_num;
u32 msgbox_addr;
u32 msgbox_ex_addr;
- struct hal_data_8723a *pHalData = GET_HAL_DATA(padapter);
+ struct hal_data_8723a *pHalData;
u32 h2c_cmd = 0;
u16 h2c_cmd_ex = 0;
int ret = _FAIL;
--
1.9.1


2015-05-12 11:07:57

by Jes Sorensen

[permalink] [raw]
Subject: Re: [PATCH] staging: rtl8723au: remove redundant initialization

"Gujulan Elango, Hari Prasath (H.)" <[email protected]> writes:
> The variable pHalData is initialized twice in this same function with
> same value.So removing one of them.
>
> Signed-off-by: Hari Prasath Gujulan Elango <[email protected]>
> ---
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Looks fine to me

Acked-by: Jes Sorensen <[email protected]>