2014-06-29 07:50:25

by Fabian Frédérick

Subject: [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree

Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Larry Finger <[email protected]>
Cc: Jes Sorensen <[email protected]>
Cc: [email protected]
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
index c8700b3..8714ae3 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -1270,8 +1270,7 @@ static void update_bcn_wps_ie(struct rtw_adapter *padapter)
pnetwork->IELength = wps_offset + (wps_ielen+2) + remainder_ielen;
}

- if (pbackup_remainder_ie)
- kfree(pbackup_remainder_ie);
+ kfree(pbackup_remainder_ie);
}

static void update_bcn_p2p_ie(struct rtw_adapter *padapter)
--
1.8.4.5

2014-07-01 07:22:40

by Jes Sorensen

Subject: Re: [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree

Fabian Frederick <[email protected]> writes:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Larry Finger <[email protected]>
> Cc: Jes Sorensen <[email protected]>
> Cc: [email protected]
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> index c8700b3..8714ae3 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -1270,8 +1270,7 @@ static void update_bcn_wps_ie(struct rtw_adapter *padapter)
> pnetwork->IELength = wps_offset + (wps_ielen+2) + remainder_ielen;
> }
>
> - if (pbackup_remainder_ie)
> - kfree(pbackup_remainder_ie);
> + kfree(pbackup_remainder_ie);
> }
>
> static void update_bcn_p2p_ie(struct rtw_adapter *padapter)

This one is no longer an issue due to other changes in my tree.

Cheers,
Jes