2008-08-12 20:48:56

by Jiri Slaby

[permalink] [raw]
Subject: iwl + iomap + readl/writel

Hi,

I spotted that iwl drivers use readl method on an iomap space. IIRC some archs
might return a tag instead of an address expected by readl/writel.

I think you should either switch to ioread32/iowrite32 or to ioremap.


2008-08-12 21:57:05

by Tomas Winkler

[permalink] [raw]
Subject: Re: iwl + iomap + readl/writel

On Wed, Aug 13, 2008 at 12:54 AM, Jiri Slaby <[email protected]> wrote:
> On 08/12/2008 11:49 PM, Tomas Winkler wrote:
>>
>> On Tue, Aug 12, 2008 at 11:48 PM, Jiri Slaby <[email protected]> wrote:
>>>
>>> Hi,
>>>
>>> I spotted that iwl drivers use readl method on an iomap space. IIRC some
>>> archs might return a tag instead of an address expected by readl/writel.
>>>
>>> I think you should either switch to ioread32/iowrite32 or to ioremap.
>>
>> Can you give me reading material on this?
>
> No, google will (you can even feel lucky).

I didn't ask for obvious answers :)

Tomas
>

2008-08-12 22:04:34

by Tomas Winkler

[permalink] [raw]
Subject: Re: iwl + iomap + readl/writel

On Wed, Aug 13, 2008 at 12:58 AM, Jiri Slaby <[email protected]> wrote:
> On 08/12/2008 11:57 PM, Tomas Winkler wrote:
>>
>> On Wed, Aug 13, 2008 at 12:54 AM, Jiri Slaby <[email protected]> wrote:
>>>
>>> On 08/12/2008 11:49 PM, Tomas Winkler wrote:
>>>>
>>>> On Tue, Aug 12, 2008 at 11:48 PM, Jiri Slaby <[email protected]>
>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I spotted that iwl drivers use readl method on an iomap space. IIRC
>>>>> some
>>>>> archs might return a tag instead of an address expected by
>>>>> readl/writel.
>>>>>
>>>>> I think you should either switch to ioread32/iowrite32 or to ioremap.
>>>>
>>>> Can you give me reading material on this?
>>>
>>> No, google will (you can even feel lucky).
>>
>> I didn't ask for obvious answers :)
>
> Sorry, I don't remember where/when this was discussed, you have to search
> for it.

It's okay I'm already digging into it

2008-08-12 21:49:52

by Tomas Winkler

[permalink] [raw]
Subject: Re: iwl + iomap + readl/writel

On Tue, Aug 12, 2008 at 11:48 PM, Jiri Slaby <[email protected]> wrote:
> Hi,
>
> I spotted that iwl drivers use readl method on an iomap space. IIRC some
> archs might return a tag instead of an address expected by readl/writel.
>
> I think you should either switch to ioread32/iowrite32 or to ioremap.

Can you give me reading material on this?
Thanks
Tomas

2008-08-12 21:54:18

by Jiri Slaby

[permalink] [raw]
Subject: Re: iwl + iomap + readl/writel

On 08/12/2008 11:49 PM, Tomas Winkler wrote:
> On Tue, Aug 12, 2008 at 11:48 PM, Jiri Slaby <[email protected]> wrote:
>> Hi,
>>
>> I spotted that iwl drivers use readl method on an iomap space. IIRC some
>> archs might return a tag instead of an address expected by readl/writel.
>>
>> I think you should either switch to ioread32/iowrite32 or to ioremap.
>
> Can you give me reading material on this?

No, google will (you can even feel lucky).

2008-08-12 21:58:18

by Jiri Slaby

[permalink] [raw]
Subject: Re: iwl + iomap + readl/writel

On 08/12/2008 11:57 PM, Tomas Winkler wrote:
> On Wed, Aug 13, 2008 at 12:54 AM, Jiri Slaby <[email protected]> wrote:
>> On 08/12/2008 11:49 PM, Tomas Winkler wrote:
>>> On Tue, Aug 12, 2008 at 11:48 PM, Jiri Slaby <[email protected]> wrote:
>>>> Hi,
>>>>
>>>> I spotted that iwl drivers use readl method on an iomap space. IIRC some
>>>> archs might return a tag instead of an address expected by readl/writel.
>>>>
>>>> I think you should either switch to ioread32/iowrite32 or to ioremap.
>>> Can you give me reading material on this?
>> No, google will (you can even feel lucky).
>
> I didn't ask for obvious answers :)

Sorry, I don't remember where/when this was discussed, you have to search for it.