2020-09-02 22:58:55

by Ben Greear

Subject: lockdep splat in kvallo ath tree

The patch below adds a call to ath10k_debug_fw_stats_request(ar),
which expects ar->conf_mutex to be held, but it is *not* held in
this code path. This leads to warnings when lockdep is enabled.


greearb@bendt7 ath10k]$ git show 4913e675630ec
commit 4913e675630ec1a15c92651f426a63755c71b91b
Author: Wen Gong <[email protected]>
Date: Thu Apr 23 10:27:58 2020 +0800

ath10k: enable rx duration report default for wmi tlv

When run command "iw dev wlan0 station dump", the rx duration is 0.
When firmware indicate WMI_UPDATE_STATS_EVENTID, extended flag of
statsis not set by default, so firmware do not report rx duration.


Thanks,
Ben

--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com

2020-09-11 08:37:06

by Kalle Valo

Subject: Re: lockdep splat in kvallo ath tree

+ ath10k

Ben Greear <[email protected]> writes:

> The patch below adds a call to ath10k_debug_fw_stats_request(ar),
> which expects ar->conf_mutex to be held, but it is *not* held in
> this code path. This leads to warnings when lockdep is enabled.
>
>
> greearb@bendt7 ath10k]$ git show 4913e675630ec
> commit 4913e675630ec1a15c92651f426a63755c71b91b
> Author: Wen Gong <[email protected]>
> Date: Thu Apr 23 10:27:58 2020 +0800
>
> ath10k: enable rx duration report default for wmi tlv
>
> When run command "iw dev wlan0 station dump", the rx duration is 0.
> When firmware indicate WMI_UPDATE_STATS_EVENTID, extended flag of
> statsis not set by default, so firmware do not report rx duration.

Wen, please investigate this.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-09-11 10:18:59

by Wen Gong

Subject: Re: lockdep splat in kvallo ath tree

On 2020-09-11 16:35, Kalle Valo wrote:
> + ath10k
>
> Ben Greear <[email protected]> writes:
>
>> The patch below adds a call to ath10k_debug_fw_stats_request(ar),
>> which expects ar->conf_mutex to be held, but it is *not* held in
>> this code path. This leads to warnings when lockdep is enabled.
>>
>>
>> greearb@bendt7 ath10k]$ git show 4913e675630ec
>> commit 4913e675630ec1a15c92651f426a63755c71b91b
>> Author: Wen Gong <[email protected]>
>> Date: Thu Apr 23 10:27:58 2020 +0800
>>
>> ath10k: enable rx duration report default for wmi tlv
>>
>> When run command "iw dev wlan0 station dump", the rx duration is
>> 0.
>> When firmware indicate WMI_UPDATE_STATS_EVENTID, extended flag of
>> statsis not set by default, so firmware do not report rx duration.
>
> Wen, please investigate this.
Yes, Kalle, I will do that.