2020-12-05 10:40:50

by Lorenzo Bianconi

[permalink] [raw]
Subject: [PATCH 1/2] mt76: usb: remove wake logic in mt76u_status_worker

Similar to mmio code path, remove wake logic in mt76u_status_worker
handler

Signed-off-by: Lorenzo Bianconi <[email protected]>
---
drivers/net/wireless/mediatek/mt76/usb.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c
index 81393788f98e..658b36a2281d 100644
--- a/drivers/net/wireless/mediatek/mt76/usb.c
+++ b/drivers/net/wireless/mediatek/mt76/usb.c
@@ -811,7 +811,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
struct mt76_dev *dev = container_of(usb, struct mt76_dev, usb);
struct mt76_queue_entry entry;
struct mt76_queue *q;
- bool wake;
int i;

for (i = 0; i < IEEE80211_NUM_ACS; i++) {
@@ -827,10 +826,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
mt76_queue_tx_complete(dev, q, &entry);
}

- wake = q->stopped && q->queued < q->ndesc - 8;
- if (wake)
- q->stopped = false;
-
if (!q->queued)
wake_up(&dev->tx_wait);

@@ -839,8 +834,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
if (dev->drv->tx_status_data &&
!test_and_set_bit(MT76_READING_STATS, &dev->phy.state))
queue_work(dev->wq, &dev->usb.stat_work);
- if (wake)
- ieee80211_wake_queue(dev->hw, i);
}
}

--
2.28.0


2020-12-17 19:13:28

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH 1/2] mt76: usb: remove wake logic in mt76u_status_worker

> Similar to mmio code path, remove wake logic in mt76u_status_worker
> handler

Starting from commit '90d494c99a99fa2eb858754345c4a9c851b409a0
("mt76: improve tx queue stop/wake")', the wake queue logic on
the usb status path is no longer necessary since the hw queues
are no longer stopped on the mt76 tx path.

Regards,
Lorenzo

>
> Signed-off-by: Lorenzo Bianconi <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/usb.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c
> index 81393788f98e..658b36a2281d 100644
> --- a/drivers/net/wireless/mediatek/mt76/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/usb.c
> @@ -811,7 +811,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
> struct mt76_dev *dev = container_of(usb, struct mt76_dev, usb);
> struct mt76_queue_entry entry;
> struct mt76_queue *q;
> - bool wake;
> int i;
>
> for (i = 0; i < IEEE80211_NUM_ACS; i++) {
> @@ -827,10 +826,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
> mt76_queue_tx_complete(dev, q, &entry);
> }
>
> - wake = q->stopped && q->queued < q->ndesc - 8;
> - if (wake)
> - q->stopped = false;
> -
> if (!q->queued)
> wake_up(&dev->tx_wait);
>
> @@ -839,8 +834,6 @@ static void mt76u_status_worker(struct mt76_worker *w)
> if (dev->drv->tx_status_data &&
> !test_and_set_bit(MT76_READING_STATS, &dev->phy.state))
> queue_work(dev->wq, &dev->usb.stat_work);
> - if (wake)
> - ieee80211_wake_queue(dev->hw, i);
> }
> }
>
> --
> 2.28.0
>


Attachments:
(No filename) (1.62 kB)
signature.asc (235.00 B)
Download all attachments

2020-12-18 05:37:59

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH 1/2] mt76: usb: remove wake logic in mt76u_status_worker

Lorenzo Bianconi <[email protected]> writes:

>> Similar to mmio code path, remove wake logic in mt76u_status_worker
>> handler
>
> Starting from commit '90d494c99a99fa2eb858754345c4a9c851b409a0
> ("mt76: improve tx queue stop/wake")', the wake queue logic on
> the usb status path is no longer necessary since the hw queues
> are no longer stopped on the mt76 tx path.

Thanks, I'll update the commit logs based on the info you provided.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-12-20 12:07:05

by Kalle Valo

[permalink] [raw]
Subject: Re: [1/2] mt76: usb: remove wake logic in mt76u_status_worker

Lorenzo Bianconi <[email protected]> wrote:

> Similar to mmio code path, remove wake logic in mt76u_status_worker handler.
> Starting from commit 90d494c99a99 ("mt76: improve tx queue stop/wake")', the
> wake queue logic on the usb status path is no longer necessary since the hw
> queues are no longer stopped on the mt76 tx path.
>
> Signed-off-by: Lorenzo Bianconi <[email protected]>

2 patches applied to wireless-drivers.git, thanks.

e16ab3db87b3 mt76: usb: remove wake logic in mt76u_status_worker
123bb2b73788 mt76: sdio: remove wake logic in mt76s_process_tx_queue

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches