2021-03-04 16:16:47

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next] iwlwifi: mvm: fix old-style static const declaration

From: Wei Yongjun <[email protected]>

GCC reports warning as follows:

drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning:
'static' is not at beginning of declaration [-Wold-style-declaration]
14 | const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
| ^~~~~

Move static to the beginning of declaration.

Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
index 873919048143..4d5a99cbcc9d 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
@@ -11,7 +11,7 @@
* DDR needs frequency in units of 16.666MHz, so provide FW with the
* frequency values in the adjusted format.
*/
-const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
+static const struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
/* LPDDR4 */

/* frequency 3733MHz */


2021-03-23 08:03:52

by Coelho, Luciano

[permalink] [raw]
Subject: Re: [PATCH -next] iwlwifi: mvm: fix old-style static const declaration

On Thu, 2021-03-04 at 10:22 +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> GCC reports warning as follows:
>
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning:
>  'static' is not at beginning of declaration [-Wold-style-declaration]
>    14 | const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
>       | ^~~~~
>
> Move static to the beginning of declaration.
>
> Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <weiyo[email protected]>
> ---

Thanks, I applied this to our internal tree and it will reach the
mainline following our usual process.

--
Cheers,
Luca.