2021-03-09 10:25:16

by Kalle Valo

[permalink] [raw]
Subject: Re: [patch 10/14] ath9k: Use tasklet_disable_in_atomic()

Thomas Gleixner <[email protected]> writes:

> From: Sebastian Andrzej Siewior <[email protected]>
>
> All callers of ath9k_beacon_ensure_primary_slot() are preemptible /
> acquire a mutex except for this callchain:
>
> spin_lock_bh(&sc->sc_pcu_lock);
> ath_complete_reset()
> -> ath9k_calculate_summary_state()
> -> ath9k_beacon_ensure_primary_slot()
>
> It's unclear how that can be distangled, so use tasklet_disable_in_atomic()
> for now. This allows tasklet_disable() to become sleepable once the
> remaining atomic users are cleaned up.
>
> Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: [email protected]
> Cc: Kalle Valo <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> drivers/net/wireless/ath/ath9k/beacon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

I assume this goes via some other tree:

Acked-by: Kalle Valo <[email protected]>

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches