On Sat, 13 Mar 2021, Kalle Valo wrote:
> >> > From: Jiri Kosina <[email protected]>
> >> >
> >> > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs
> >> > disabled (e.g. from LED core). We can't enable BHs in such a situation.
> >> >
> >> > Turn the unconditional BH-enable/BH-disable code into
> >> > hardirq-disable/conditional-enable.
> >> >
> >> > This fixes the warning below.
> >>
> >> Hi,
> >>
> >> friendly ping on this one ...
> >
> > Luca,
> >
> > Johannes is telling me that he merged this patch internally, but I have no
> > idea what is happening to it ... ?
> >
> > The reported splat is a clear bug, so it should be fixed one way or the
> > other.
>
> Should I take this to wireless-drivers?
I can't speak for the maintainers, but as far as I am concerned, it
definitely is a 5.12 material, as it fixes real scheduling bug.
Thanks,
--
Jiri Kosina
SUSE Labs
On Sat, 2021-03-13 at 16:43 +0100, Jiri Kosina wrote:
> On Sat, 13 Mar 2021, Kalle Valo wrote:
>
> > > > > From: Jiri Kosina <[email protected]>
> > > > >
> > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs
> > > > > disabled (e.g. from LED core). We can't enable BHs in such a situation.
> > > > >
> > > > > Turn the unconditional BH-enable/BH-disable code into
> > > > > hardirq-disable/conditional-enable.
> > > > >
> > > > > This fixes the warning below.
> > > >
> > > > Hi,
> > > >
> > > > friendly ping on this one ...
> > >
> > > Luca,
> > >
> > > Johannes is telling me that he merged this patch internally, but I have no
> > > idea what is happening to it ... ?
> > >
> > > The reported splat is a clear bug, so it should be fixed one way or the
> > > other.
> >
> > Should I take this to wireless-drivers?
>
> I can't speak for the maintainers, but as far as I am concerned, it
> definitely is a 5.12 material, as it fixes real scheduling bug.
Yes, please take this to w-d. We have a similar patch internally, but
there's a backlog and it will take me some time to get to it. I'll
resolve eventual conflicts when time comes.
Thanks!
--
Cheers,
Luca.
Luca Coelho <[email protected]> writes:
> On Sat, 2021-03-13 at 16:43 +0100, Jiri Kosina wrote:
>> On Sat, 13 Mar 2021, Kalle Valo wrote:
>>
>> > > > > From: Jiri Kosina <[email protected]>
>> > > > >
>> > > > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs
>> > > > > disabled (e.g. from LED core). We can't enable BHs in such a situation.
>> > > > >
>> > > > > Turn the unconditional BH-enable/BH-disable code into
>> > > > > hardirq-disable/conditional-enable.
>> > > > >
>> > > > > This fixes the warning below.
>> > > >
>> > > > Hi,
>> > > >
>> > > > friendly ping on this one ...
>> > >
>> > > Luca,
>> > >
>> > > Johannes is telling me that he merged this patch internally, but I have no
>> > > idea what is happening to it ... ?
>> > >
>> > > The reported splat is a clear bug, so it should be fixed one way or the
>> > > other.
>> >
>> > Should I take this to wireless-drivers?
>>
>> I can't speak for the maintainers, but as far as I am concerned, it
>> definitely is a 5.12 material, as it fixes real scheduling bug.
>
> Yes, please take this to w-d. We have a similar patch internally, but
> there's a backlog and it will take me some time to get to it. I'll
> resolve eventual conflicts when time comes.
Ok, can I have your ack for patchwork?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches