2021-05-20 09:51:22

by Kalle Valo

[permalink] [raw]
Subject: [regressions] ath11k: v5.12.3 mhi regression

Hi,

I got several reports that this mhi commit broke ath11k in v5.12.3:

commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
Author: Bhaumik Bhatt <[email protected]>
Date: Wed Feb 24 15:23:04 2021 -0800

bus: mhi: core: Process execution environment changes serially

[ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]

Here are the reports:

https://bugzilla.kernel.org/show_bug.cgi?id=213055

https://bugzilla.kernel.org/show_bug.cgi?id=212187

https://bugs.archlinux.org/task/70849?project=1&string=linux

Interestingly v5.13-rc1 seems to work fine, at least for me, though I
have not tested v5.12.3 myself. Can someone revert this commit in the
stable release so that people get their wifi working again, please?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


2021-05-20 11:28:24

by Greg KH

[permalink] [raw]
Subject: Re: [regressions] ath11k: v5.12.3 mhi regression

On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote:
> Hi,
>
> I got several reports that this mhi commit broke ath11k in v5.12.3:
>
> commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
> Author: Bhaumik Bhatt <[email protected]>
> Date: Wed Feb 24 15:23:04 2021 -0800
>
> bus: mhi: core: Process execution environment changes serially
>
> [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
>
> Here are the reports:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=213055
>
> https://bugzilla.kernel.org/show_bug.cgi?id=212187
>
> https://bugs.archlinux.org/task/70849?project=1&string=linux
>
> Interestingly v5.13-rc1 seems to work fine, at least for me, though I
> have not tested v5.12.3 myself. Can someone revert this commit in the
> stable release so that people get their wifi working again, please?

How does the mhi bus code relate to a ath11k driver? What bus is that
on?

This seems odd...

greg k-h

2021-05-20 12:09:29

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [regressions] ath11k: v5.12.3 mhi regression

On Thu, May 20, 2021 at 12:02:40PM +0200, Greg KH wrote:
> On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote:
> > Hi,
> >
> > I got several reports that this mhi commit broke ath11k in v5.12.3:
> >
> > commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
> > Author: Bhaumik Bhatt <[email protected]>
> > Date: Wed Feb 24 15:23:04 2021 -0800
> >
> > bus: mhi: core: Process execution environment changes serially
> >
> > [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
> >
> > Here are the reports:
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=213055
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=212187
> >
> > https://bugs.archlinux.org/task/70849?project=1&string=linux
> >
> > Interestingly v5.13-rc1 seems to work fine, at least for me, though I
> > have not tested v5.12.3 myself. Can someone revert this commit in the
> > stable release so that people get their wifi working again, please?
>
> How does the mhi bus code relate to a ath11k driver? What bus is that
> on?
>

MHI is the transport used by the ath11k driver to work with the WLAN devices
over PCIe.

Regarding the bug, I'd suggest to wait for Bhaumik (the author of 29b9829718c5)
to comment on the possible commit which needs backporting from mainline.

Thanks,
Mani

> This seems odd...
>
> greg k-h

2021-05-20 12:40:35

by Kalle Valo

[permalink] [raw]
Subject: Re: [regressions] ath11k: v5.12.3 mhi regression

Manivannan Sadhasivam <[email protected]> writes:

> On Thu, May 20, 2021 at 12:02:40PM +0200, Greg KH wrote:
>> On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote:
>> > Hi,
>> >
>> > I got several reports that this mhi commit broke ath11k in v5.12.3:
>> >
>> > commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
>> > Author: Bhaumik Bhatt <[email protected]>
>> > Date: Wed Feb 24 15:23:04 2021 -0800
>> >
>> > bus: mhi: core: Process execution environment changes serially
>> >
>> > [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
>> >
>> > Here are the reports:
>> >
>> > https://bugzilla.kernel.org/show_bug.cgi?id=213055
>> >
>> > https://bugzilla.kernel.org/show_bug.cgi?id=212187
>> >
>> > https://bugs.archlinux.org/task/70849?project=1&string=linux
>> >
>> > Interestingly v5.13-rc1 seems to work fine, at least for me, though I
>> > have not tested v5.12.3 myself. Can someone revert this commit in the
>> > stable release so that people get their wifi working again, please?
>>
>> How does the mhi bus code relate to a ath11k driver? What bus is that
>> on?
>>
>
> MHI is the transport used by the ath11k driver to work with the WLAN devices
> over PCIe.
>
> Regarding the bug, I'd suggest to wait for Bhaumik (the author of 29b9829718c5)
> to comment on the possible commit which needs backporting from mainline.

Ok, but if a quick fix is not available I think we should just revert
this in the stable releases. I also got a report that v5.11.21 is
broken:

https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2021-05-21 06:41:51

by Bhaumik Bhatt

[permalink] [raw]
Subject: Re: [regressions] ath11k: v5.12.3 mhi regression

On 2021-05-20 05:36 AM, Kalle Valo wrote:
> Manivannan Sadhasivam <[email protected]> writes:
>
>> On Thu, May 20, 2021 at 12:02:40PM +0200, Greg KH wrote:
>>> On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote:
>>> > Hi,
>>> >
>>> > I got several reports that this mhi commit broke ath11k in v5.12.3:
>>> >
>>> > commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
>>> > Author: Bhaumik Bhatt <[email protected]>
>>> > Date: Wed Feb 24 15:23:04 2021 -0800
>>> >
>>> > bus: mhi: core: Process execution environment changes serially
>>> >
>>> > [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
>>> >
>>> > Here are the reports:
>>> >
>>> > https://bugzilla.kernel.org/show_bug.cgi?id=213055
>>> >
>>> > https://bugzilla.kernel.org/show_bug.cgi?id=212187
>>> >
>>> > https://bugs.archlinux.org/task/70849?project=1&string=linux
>>> >
>>> > Interestingly v5.13-rc1 seems to work fine, at least for me, though I
>>> > have not tested v5.12.3 myself. Can someone revert this commit in the
>>> > stable release so that people get their wifi working again, please?
>>>
>>> How does the mhi bus code relate to a ath11k driver? What bus is
>>> that
>>> on?
>>>
>>
>> MHI is the transport used by the ath11k driver to work with the WLAN
>> devices
>> over PCIe.
>>
>> Regarding the bug, I'd suggest to wait for Bhaumik (the author of
>> 29b9829718c5)
>> to comment on the possible commit which needs backporting from
>> mainline.
>
> Ok, but if a quick fix is not available I think we should just revert
> this in the stable releases. I also got a report that v5.11.21 is
> broken:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11

Please pick [1] as the dependency to [ Upstream commit
ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].

That is missing in older kernels and did not get backported.
This explains why 5.13.x works.

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/bus/mhi/core?h=v5.13-rc2&id=4884362f6977fc05cbec736625665241c0e0732f

2021-05-21 06:43:51

by Greg KH

[permalink] [raw]
Subject: Re: [regressions] ath11k: v5.12.3 mhi regression

On Thu, May 20, 2021 at 10:38:12AM -0700, Bhaumik Bhatt wrote:
> On 2021-05-20 05:36 AM, Kalle Valo wrote:
> > Manivannan Sadhasivam <[email protected]> writes:
> >
> > > On Thu, May 20, 2021 at 12:02:40PM +0200, Greg KH wrote:
> > > > On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote:
> > > > > Hi,
> > > > >
> > > > > I got several reports that this mhi commit broke ath11k in v5.12.3:
> > > > >
> > > > > commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
> > > > > Author: Bhaumik Bhatt <[email protected]>
> > > > > Date: Wed Feb 24 15:23:04 2021 -0800
> > > > >
> > > > > bus: mhi: core: Process execution environment changes serially
> > > > >
> > > > > [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
> > > > >
> > > > > Here are the reports:
> > > > >
> > > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055
> > > > >
> > > > > https://bugzilla.kernel.org/show_bug.cgi?id=212187
> > > > >
> > > > > https://bugs.archlinux.org/task/70849?project=1&string=linux
> > > > >
> > > > > Interestingly v5.13-rc1 seems to work fine, at least for me, though I
> > > > > have not tested v5.12.3 myself. Can someone revert this commit in the
> > > > > stable release so that people get their wifi working again, please?
> > > >
> > > > How does the mhi bus code relate to a ath11k driver? What bus
> > > > is that
> > > > on?
> > > >
> > >
> > > MHI is the transport used by the ath11k driver to work with the WLAN
> > > devices
> > > over PCIe.
> > >
> > > Regarding the bug, I'd suggest to wait for Bhaumik (the author of
> > > 29b9829718c5)
> > > to comment on the possible commit which needs backporting from
> > > mainline.
> >
> > Ok, but if a quick fix is not available I think we should just revert
> > this in the stable releases. I also got a report that v5.11.21 is
> > broken:
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11
>
> Please pick [1] as the dependency to [ Upstream commit
> ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].

what is [1]???

What commit do I need to backport, a commit id would be nice...

thanks,

greg k-h

2021-05-21 06:44:03

by Bhaumik Bhatt

[permalink] [raw]
Subject: Re: [regressions] ath11k: v5.12.3 mhi regression

On 2021-05-20 10:58 AM, Greg KH wrote:
> On Thu, May 20, 2021 at 10:38:12AM -0700, Bhaumik Bhatt wrote:
>> On 2021-05-20 05:36 AM, Kalle Valo wrote:
>> > Manivannan Sadhasivam <[email protected]> writes:
>> >
>> > > On Thu, May 20, 2021 at 12:02:40PM +0200, Greg KH wrote:
>> > > > On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote:
>> > > > > Hi,
>> > > > >
>> > > > > I got several reports that this mhi commit broke ath11k in v5.12.3:
>> > > > >
>> > > > > commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
>> > > > > Author: Bhaumik Bhatt <[email protected]>
>> > > > > Date: Wed Feb 24 15:23:04 2021 -0800
>> > > > >
>> > > > > bus: mhi: core: Process execution environment changes serially
>> > > > >
>> > > > > [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
>> > > > >
>> > > > > Here are the reports:
>> > > > >
>> > > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055
>> > > > >
>> > > > > https://bugzilla.kernel.org/show_bug.cgi?id=212187
>> > > > >
>> > > > > https://bugs.archlinux.org/task/70849?project=1&string=linux
>> > > > >
>> > > > > Interestingly v5.13-rc1 seems to work fine, at least for me, though I
>> > > > > have not tested v5.12.3 myself. Can someone revert this commit in the
>> > > > > stable release so that people get their wifi working again, please?
>> > > >
>> > > > How does the mhi bus code relate to a ath11k driver? What bus
>> > > > is that
>> > > > on?
>> > > >
>> > >
>> > > MHI is the transport used by the ath11k driver to work with the WLAN
>> > > devices
>> > > over PCIe.
>> > >
>> > > Regarding the bug, I'd suggest to wait for Bhaumik (the author of
>> > > 29b9829718c5)
>> > > to comment on the possible commit which needs backporting from
>> > > mainline.
>> >
>> > Ok, but if a quick fix is not available I think we should just revert
>> > this in the stable releases. I also got a report that v5.11.21 is
>> > broken:
>> >
>> > https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11
>>
>> Please pick [1] as the dependency to [ Upstream commit
>> ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].
>
> what is [1]???
>
> What commit do I need to backport, a commit id would be nice...
>
> thanks,
>
> greg k-h
Sure Greg. Commit id is: 4884362f6977fc05cbec736625665241c0e0732f

Title of patch:
bus: mhi: core: Download AMSS image from appropriate function

It was supposed to be a link but not sure why it's not seen.

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project

2021-05-21 06:45:06

by Greg KH

[permalink] [raw]
Subject: Re: [regressions] ath11k: v5.12.3 mhi regression

On Thu, May 20, 2021 at 11:04:05AM -0700, Bhaumik Bhatt wrote:
> On 2021-05-20 10:58 AM, Greg KH wrote:
> > On Thu, May 20, 2021 at 10:38:12AM -0700, Bhaumik Bhatt wrote:
> > > On 2021-05-20 05:36 AM, Kalle Valo wrote:
> > > > Manivannan Sadhasivam <[email protected]> writes:
> > > >
> > > > > On Thu, May 20, 2021 at 12:02:40PM +0200, Greg KH wrote:
> > > > > > On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I got several reports that this mhi commit broke ath11k in v5.12.3:
> > > > > > >
> > > > > > > commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
> > > > > > > Author: Bhaumik Bhatt <[email protected]>
> > > > > > > Date: Wed Feb 24 15:23:04 2021 -0800
> > > > > > >
> > > > > > > bus: mhi: core: Process execution environment changes serially
> > > > > > >
> > > > > > > [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
> > > > > > >
> > > > > > > Here are the reports:
> > > > > > >
> > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055
> > > > > > >
> > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=212187
> > > > > > >
> > > > > > > https://bugs.archlinux.org/task/70849?project=1&string=linux
> > > > > > >
> > > > > > > Interestingly v5.13-rc1 seems to work fine, at least for me, though I
> > > > > > > have not tested v5.12.3 myself. Can someone revert this commit in the
> > > > > > > stable release so that people get their wifi working again, please?
> > > > > >
> > > > > > How does the mhi bus code relate to a ath11k driver? What bus
> > > > > > is that
> > > > > > on?
> > > > > >
> > > > >
> > > > > MHI is the transport used by the ath11k driver to work with the WLAN
> > > > > devices
> > > > > over PCIe.
> > > > >
> > > > > Regarding the bug, I'd suggest to wait for Bhaumik (the author of
> > > > > 29b9829718c5)
> > > > > to comment on the possible commit which needs backporting from
> > > > > mainline.
> > > >
> > > > Ok, but if a quick fix is not available I think we should just revert
> > > > this in the stable releases. I also got a report that v5.11.21 is
> > > > broken:
> > > >
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11
> > >
> > > Please pick [1] as the dependency to [ Upstream commit
> > > ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].
> >
> > what is [1]???
> >
> > What commit do I need to backport, a commit id would be nice...
> >
> > thanks,
> >
> > greg k-h
> Sure Greg. Commit id is: 4884362f6977fc05cbec736625665241c0e0732f
>
> Title of patch:
> bus: mhi: core: Download AMSS image from appropriate function
>
> It was supposed to be a link but not sure why it's not seen.

Text email doesn't have links :)

Anyway, thanks, now queued up.

Also note, it's nice to write kernel commit ids as 4884362f6977 ("bus:
mhi: core: Download AMSS image from appropriate function") which is the
preferred way to reference them in a emails and commit logs.

thanks,

greg k-h

2021-05-24 05:57:13

by Kalle Valo

[permalink] [raw]
Subject: Re: [regressions] ath11k: v5.12.3 mhi regression

Greg KH <[email protected]> writes:

> On Thu, May 20, 2021 at 11:04:05AM -0700, Bhaumik Bhatt wrote:
>> On 2021-05-20 10:58 AM, Greg KH wrote:
>> > On Thu, May 20, 2021 at 10:38:12AM -0700, Bhaumik Bhatt wrote:
>> > > On 2021-05-20 05:36 AM, Kalle Valo wrote:
>> > > > Manivannan Sadhasivam <[email protected]> writes:
>> > > >
>> > > > > On Thu, May 20, 2021 at 12:02:40PM +0200, Greg KH wrote:
>> > > > > > On Thu, May 20, 2021 at 12:47:53PM +0300, Kalle Valo wrote:
>> > > > > > > Hi,
>> > > > > > >
>> > > > > > > I got several reports that this mhi commit broke ath11k in v5.12.3:
>> > > > > > >
>> > > > > > > commit 29b9829718c5e9bd68fc1c652f5e0ba9b9a64fed
>> > > > > > > Author: Bhaumik Bhatt <[email protected]>
>> > > > > > > Date: Wed Feb 24 15:23:04 2021 -0800
>> > > > > > >
>> > > > > > > bus: mhi: core: Process execution environment changes serially
>> > > > > > >
>> > > > > > > [ Upstream commit ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ]
>> > > > > > >
>> > > > > > > Here are the reports:
>> > > > > > >
>> > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055
>> > > > > > >
>> > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=212187
>> > > > > > >
>> > > > > > > https://bugs.archlinux.org/task/70849?project=1&string=linux
>> > > > > > >
>> > > > > > > Interestingly v5.13-rc1 seems to work fine, at least for me, though I
>> > > > > > > have not tested v5.12.3 myself. Can someone revert this commit in the
>> > > > > > > stable release so that people get their wifi working again, please?
>> > > > > >
>> > > > > > How does the mhi bus code relate to a ath11k driver? What bus
>> > > > > > is that
>> > > > > > on?
>> > > > > >
>> > > > >
>> > > > > MHI is the transport used by the ath11k driver to work with the WLAN
>> > > > > devices
>> > > > > over PCIe.
>> > > > >
>> > > > > Regarding the bug, I'd suggest to wait for Bhaumik (the author of
>> > > > > 29b9829718c5)
>> > > > > to comment on the possible commit which needs backporting from
>> > > > > mainline.
>> > > >
>> > > > Ok, but if a quick fix is not available I think we should just revert
>> > > > this in the stable releases. I also got a report that v5.11.21 is
>> > > > broken:
>> > > >
>> > > > https://bugzilla.kernel.org/show_bug.cgi?id=213055#c11
>> > >
>> > > Please pick [1] as the dependency to [ Upstream commit
>> > > ef2126c4e2ea2b92f543fae00a2a0332e4573c48 ].
>> >
>> > what is [1]???
>> >
>> > What commit do I need to backport, a commit id would be nice...
>> >
>> > thanks,
>> >
>> > greg k-h
>> Sure Greg. Commit id is: 4884362f6977fc05cbec736625665241c0e0732f
>>
>> Title of patch:
>> bus: mhi: core: Download AMSS image from appropriate function
>>
>> It was supposed to be a link but not sure why it's not seen.
>
> Text email doesn't have links :)
>
> Anyway, thanks, now queued up.

I'm now getting confirmations that this issue is fixed in v5.12.6.
Thanks for the quick fix and the quick new release!

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches