2021-05-22 09:54:02

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] ath11k: Fix an error handling path in 'ath11k_core_fetch_board_data_api_n()'

All error paths but this one 'goto err' in order to release some
resources.
Fix this.

Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/wireless/ath/ath11k/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 77ce3347ab86..595e83fe0990 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -488,7 +488,8 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *ab,
if (len < ALIGN(ie_len, 4)) {
ath11k_err(ab, "invalid length for board ie_id %d ie_len %zu len %zu\n",
ie_id, ie_len, len);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err;
}

switch (ie_id) {
--
2.30.2


2021-06-15 14:05:29

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath11k: Fix an error handling path in 'ath11k_core_fetch_board_data_api_n()'

Christophe JAILLET <[email protected]> wrote:

> All error paths but this one 'goto err' in order to release some
> resources.
> Fix this.
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Christophe JAILLET <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

515bda1d1e51 ath11k: Fix an error handling path in ath11k_core_fetch_board_data_api_n()

--
https://patchwork.kernel.org/project/linux-wireless/patch/e959eb544f3[email protected]wanadoo.fr/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches