2021-07-06 10:52:16

by Johan Hovold

[permalink] [raw]
Subject: Re: [PATCH] bus: Make remove callback return void

On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> Signed-off-by: Uwe Kleine-König <[email protected]>

> drivers/staging/greybus/gbphy.c | 4 +---

> drivers/usb/serial/bus.c | 4 +---

> include/linux/device/bus.h | 2 +-

Acked-by: Johan Hovold <[email protected]>