2021-09-13 08:34:29

by Jérôme Pouiller

Subject: [PATCH v2 13/33] staging: wfx: update with the firmware API 3.8

From: Jérôme Pouiller <[email protected]>

The firmware API 3.8 introduces new statistic counters. These changes
are backward compatible.

Signed-off-by: Jérôme Pouiller <[email protected]>
---
drivers/staging/wfx/debug.c | 3 +++
drivers/staging/wfx/hif_api_mib.h | 5 ++++-
2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c
index eedada78c25f..e67ca0d818ba 100644
--- a/drivers/staging/wfx/debug.c
+++ b/drivers/staging/wfx/debug.c
@@ -109,6 +109,9 @@ static int wfx_counters_show(struct seq_file *seq, void *v)

PUT_COUNTER(rx_beacon);
PUT_COUNTER(miss_beacon);
+ PUT_COUNTER(rx_dtim);
+ PUT_COUNTER(rx_dtim_aid0_clr);
+ PUT_COUNTER(rx_dtim_aid0_set);

#undef PUT_COUNTER

diff --git a/drivers/staging/wfx/hif_api_mib.h b/drivers/staging/wfx/hif_api_mib.h
index ace924720ce6..b2dc47c314cc 100644
--- a/drivers/staging/wfx/hif_api_mib.h
+++ b/drivers/staging/wfx/hif_api_mib.h
@@ -158,7 +158,10 @@ struct hif_mib_extended_count_table {
__le32 count_rx_bipmic_errors;
__le32 count_rx_beacon;
__le32 count_miss_beacon;
- __le32 reserved[15];
+ __le32 count_rx_dtim;
+ __le32 count_rx_dtim_aid0_clr;
+ __le32 count_rx_dtim_aid0_set;
+ __le32 reserved[12];
} __packed;

struct hif_mib_count_table {
--
2.33.0

2021-09-13 10:07:09

by Dan Carpenter

Subject: Re: [PATCH v2 13/33] staging: wfx: update with the firmware API 3.8

On Mon, Sep 13, 2021 at 10:30:25AM +0200, Jerome Pouiller wrote:
> From: J?r?me Pouiller <[email protected]>
>
> The firmware API 3.8 introduces new statistic counters. These changes
> are backward compatible.
>
> Signed-off-by: J?r?me Pouiller <[email protected]>
> ---
> drivers/staging/wfx/debug.c | 3 +++
> drivers/staging/wfx/hif_api_mib.h | 5 ++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c
> index eedada78c25f..e67ca0d818ba 100644
> --- a/drivers/staging/wfx/debug.c
> +++ b/drivers/staging/wfx/debug.c
> @@ -109,6 +109,9 @@ static int wfx_counters_show(struct seq_file *seq, void *v)
>
> PUT_COUNTER(rx_beacon);
> PUT_COUNTER(miss_beacon);
> + PUT_COUNTER(rx_dtim);
> + PUT_COUNTER(rx_dtim_aid0_clr);
> + PUT_COUNTER(rx_dtim_aid0_set);
>
> #undef PUT_COUNTER

Not related to the patch but the PUT_COUNTER macro should be called
something like PRINT_COUNTER. It's not a get/put API.

regards,
dan carpenter