2023-07-31 13:08:37

by Jinjie Ruan

Subject: [PATCH -next] ath9k: Remove unnecessary ternary operators

Ther are a little ternary operators, the true or false judgement
of which is unnecessary in C language semantics.

Signed-off-by: Ruan Jinjie <[email protected]>
---
drivers/net/wireless/ath/ath9k/eeprom_9287.c | 3 +--
drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +-
drivers/net/wireless/ath/ath9k/htc_drv_main.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/eeprom_9287.c b/drivers/net/wireless/ath/ath9k/eeprom_9287.c
index 3caa149b1013..fd5312c2a7e3 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom_9287.c
+++ b/drivers/net/wireless/ath/ath9k/eeprom_9287.c
@@ -572,8 +572,7 @@ static void ath9k_hw_set_ar9287_power_per_rate_table(struct ath_hw *ah,
}

for (ctlMode = 0; ctlMode < numCtlModes; ctlMode++) {
- bool isHt40CtlMode =
- (pCtlMode[ctlMode] == CTL_2GHT40) ? true : false;
+ bool isHt40CtlMode = pCtlMode[ctlMode] == CTL_2GHT40;

if (isHt40CtlMode)
freq = centers.synth_center;
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
index 27ff1ca2631f..e5414435b141 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
@@ -1432,7 +1432,7 @@ static void ath9k_hif_usb_disconnect(struct usb_interface *interface)
{
struct usb_device *udev = interface_to_usbdev(interface);
struct hif_device_usb *hif_dev = usb_get_intfdata(interface);
- bool unplugged = (udev->state == USB_STATE_NOTATTACHED) ? true : false;
+ bool unplugged = udev->state == USB_STATE_NOTATTACHED;

if (!hif_dev)
return;
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index 51766de5ec3b..44e02cfe2438 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -719,7 +719,7 @@ static int ath9k_htc_tx_aggr_oper(struct ath9k_htc_priv *priv,

aggr.sta_index = ista->index;
aggr.tidno = tid & 0xf;
- aggr.aggr_enable = (action == IEEE80211_AMPDU_TX_START) ? true : false;
+ aggr.aggr_enable = action == IEEE80211_AMPDU_TX_START;

WMI_CMD_BUF(WMI_TX_AGGR_ENABLE_CMDID, &aggr);
if (ret)
--
2.34.1

2023-08-04 01:39:11

by Jinjie Ruan

Subject: Re: [PATCH -next] ath9k: Remove unnecessary ternary operators

Ping.

On 2023/7/31 20:44, Ruan Jinjie wrote:
> Ther are a little ternary operators, the true or false judgement
> of which is unnecessary in C language semantics.
>
> Signed-off-by: Ruan Jinjie <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/eeprom_9287.c | 3 +--
> drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +-
> drivers/net/wireless/ath/ath9k/htc_drv_main.c | 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/eeprom_9287.c b/drivers/net/wireless/ath/ath9k/eeprom_9287.c
> index 3caa149b1013..fd5312c2a7e3 100644
> --- a/drivers/net/wireless/ath/ath9k/eeprom_9287.c
> +++ b/drivers/net/wireless/ath/ath9k/eeprom_9287.c
> @@ -572,8 +572,7 @@ static void ath9k_hw_set_ar9287_power_per_rate_table(struct ath_hw *ah,
> }
>
> for (ctlMode = 0; ctlMode < numCtlModes; ctlMode++) {
> - bool isHt40CtlMode =
> - (pCtlMode[ctlMode] == CTL_2GHT40) ? true : false;
> + bool isHt40CtlMode = pCtlMode[ctlMode] == CTL_2GHT40;
>
> if (isHt40CtlMode)
> freq = centers.synth_center;
> diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
> index 27ff1ca2631f..e5414435b141 100644
> --- a/drivers/net/wireless/ath/ath9k/hif_usb.c
> +++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
> @@ -1432,7 +1432,7 @@ static void ath9k_hif_usb_disconnect(struct usb_interface *interface)
> {
> struct usb_device *udev = interface_to_usbdev(interface);
> struct hif_device_usb *hif_dev = usb_get_intfdata(interface);
> - bool unplugged = (udev->state == USB_STATE_NOTATTACHED) ? true : false;
> + bool unplugged = udev->state == USB_STATE_NOTATTACHED;
>
> if (!hif_dev)
> return;
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> index 51766de5ec3b..44e02cfe2438 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> @@ -719,7 +719,7 @@ static int ath9k_htc_tx_aggr_oper(struct ath9k_htc_priv *priv,
>
> aggr.sta_index = ista->index;
> aggr.tidno = tid & 0xf;
> - aggr.aggr_enable = (action == IEEE80211_AMPDU_TX_START) ? true : false;
> + aggr.aggr_enable = action == IEEE80211_AMPDU_TX_START;
>
> WMI_CMD_BUF(WMI_TX_AGGR_ENABLE_CMDID, &aggr);
> if (ret)

2023-08-04 07:11:21

by Kalle Valo

Subject: Re: [PATCH -next] ath9k: Remove unnecessary ternary operators

Ruan Jinjie <[email protected]> writes:

> Ping.

Please don't top post. And also don't ping, you can check the patch
status from our patchwork. Read more from the wiki link below.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2023-08-04 09:45:59

by Toke Høiland-Jørgensen

Subject: Re: [PATCH -next] ath9k: Remove unnecessary ternary operators

Kalle Valo <[email protected]> writes:

> Ruan Jinjie <[email protected]> writes:
>
>> Ping.
>
> Please don't top post. And also don't ping, you can check the patch
> status from our patchwork. Read more from the wiki link below.

Also, in this case the maintainer is on holiday :)

I'll be back starting next week, but will probably take some time
getting through my backlog...

-Toke

2023-08-08 18:09:29

by Toke Høiland-Jørgensen

Subject: Re: [PATCH -next] ath9k: Remove unnecessary ternary operators

Ruan Jinjie <[email protected]> writes:

> Ther are a little ternary operators, the true or false judgement
> of which is unnecessary in C language semantics.
>
> Signed-off-by: Ruan Jinjie <[email protected]>

Acked-by: Toke Høiland-Jørgensen <[email protected]>