On Thu, 11 Apr 2024 06:59:27 -0700 Breno Leitao wrote:
> +/**
> + * alloc_netdev_dummy - Allocate and initialize a dummy net device.
> + * @sizeof_priv: size of private data to allocate space for
> + */
> +struct net_device *alloc_netdev_dummy(int sizeof_priv)
Sorry, one more round :)
We started using -Wall for kdoc (./scripts/kernel-doc -Wall $files)
recently and it now complains about missing return values...
From: Jakub Kicinski <[email protected]>
Date: Fri, 12 Apr 2024 19:16:26 -0700
> On Thu, 11 Apr 2024 06:59:27 -0700 Breno Leitao wrote:
>> +/**
>> + * alloc_netdev_dummy - Allocate and initialize a dummy net device.
>> + * @sizeof_priv: size of private data to allocate space for
>> + */
>> +struct net_device *alloc_netdev_dummy(int sizeof_priv)
>
> Sorry, one more round :)
>
> We started using -Wall for kdoc (./scripts/kernel-doc -Wall $files)
> recently and it now complains about missing return values...
Just FYI: kdoc accepts only this pattern:
* @last_param: blah
*
* Return: blah
NOT
* Returns: blah
neither
* Returns blah
Only "Return: blah" with a blank newline between it and the last
argument (or extended description).
Thanks,
Olek