2024-02-13 10:05:50

by Randy Dunlap

Subject: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of depending on it

IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
it directly thru "make *config", so drivers should select it instead
of depending on it if they need it.
Relying on it being set for a dependency is risky.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change EXTCON_MAX8997's use of "depends on" for
IRQ_DOMAIN to "select".

Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: MyungJoo Ham <[email protected]>
Cc: Chanwoo Choi <[email protected]>
Cc: Marc Zyngier <[email protected]>
Cc: Philipp Zabel <[email protected]>
Cc: Peter Rosin <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
v2: drop Cc: Donggeun Kim <[email protected]> (bounced)

drivers/extcon/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -116,7 +116,8 @@ config EXTCON_MAX77843

config EXTCON_MAX8997
tristate "Maxim MAX8997 EXTCON Support"
- depends on MFD_MAX8997 && IRQ_DOMAIN
+ depends on MFD_MAX8997
+ select IRQ_DOMAIN
help
If you say yes here you get support for the MUIC device of
Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory

2024-02-22 05:56:33

by Chanwoo Choi

Subject: RE: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of depending on it

> -----Original Message-----
> From: Randy Dunlap <[email protected]>
> Sent: Tuesday, February 13, 2024 3:00 PM
> To: [email protected]
> Cc: Randy Dunlap <[email protected]>; Arnd Bergmann <[email protected]>;
> MyungJoo Ham <[email protected]>; Chanwoo Choi
<[email protected]>;
> Marc Zyngier <[email protected]>; Philipp Zabel <[email protected]>;
Peter
> Rosin <[email protected]>; Greg Kroah-Hartman <[email protected]>
> Subject: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of
depending
> on it
>
> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
> Relying on it being set for a dependency is risky.
>
> Consistently using "select" or "depends on" can also help reduce Kconfig
> circular dependency issues.
>
> Therefore, change EXTCON_MAX8997's use of "depends on" for IRQ_DOMAIN to
> "select".
>
> Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: MyungJoo Ham <[email protected]>
> Cc: Chanwoo Choi <[email protected]>
> Cc: Marc Zyngier <[email protected]>
> Cc: Philipp Zabel <[email protected]>
> Cc: Peter Rosin <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> ---
> v2: drop Cc: Donggeun Kim <[email protected]> (bounced)
>
> drivers/extcon/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -116,7 +116,8 @@ config EXTCON_MAX77843
>
> config EXTCON_MAX8997
> tristate "Maxim MAX8997 EXTCON Support"
> - depends on MFD_MAX8997 && IRQ_DOMAIN
> + depends on MFD_MAX8997
> + select IRQ_DOMAIN
> help
> If you say yes here you get support for the MUIC device of
> Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory

Applied it. Thanks.

Best Regards,
Chanwoo Choi