2021-09-22 22:21:37

by Stephen Boyd

Subject: Re: [PATCH] ath10k: Don't always treat modem stop events as crashes

Quoting [email protected] (2021-09-21 22:35:34)
>
>
> On 9/5/21 4:04 PM, Stephen Boyd wrote:
>
> > +static int ath10k_snoc_modem_notify(struct notifier_block *nb, unsigned long
[...]
>
> > +
>
> > + return NOTIFY_OK;
>
> > +}
>
>
>
> Thanks for posting the patch. It would be preferable to use a different flag
> instead of ATH10K_SNOC_FLAG_UNREGISTERING,
>
> since we are not unloading the ath10k driver.
>
>

Ok. I'll make a new flag ATH10K_SNOC_FLAG_MODEM_STOPPED and test that as
well.

2021-09-24 08:05:55

by Kalle Valo

Subject: Re: [PATCH] ath10k: Don't always treat modem stop events as crashes

Stephen Boyd <[email protected]> writes:

> Quoting [email protected] (2021-09-21 22:35:34)
>> On 9/5/21 4:04 PM, Stephen Boyd wrote:
>>
>> > +static int ath10k_snoc_modem_notify(struct notifier_block *nb, unsigned long
> [...]
>>
>> > +
>>
>> > + return NOTIFY_OK;
>>
>> > +}
>>
>>
>>
>> Thanks for posting the patch. It would be preferable to use a different flag
>> instead of ATH10K_SNOC_FLAG_UNREGISTERING,
>>
>> since we are not unloading the ath10k driver.

Weird, I don't see pillair's email on patchwork[1] and not in the ath10k
list either. Was it sent as HTML or something?

[1] https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2021-09-24 08:10:42

by Rakesh Pillai

Subject: RE: [PATCH] ath10k: Don't always treat modem stop events as crashes

> -----Original Message-----
> From: Kalle Valo <[email protected]>
> Sent: Friday, September 24, 2021 1:30 PM
> To: Stephen Boyd <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH] ath10k: Don't always treat modem stop events as
> crashes
>
> Stephen Boyd <[email protected]> writes:
>
> > Quoting [email protected] (2021-09-21 22:35:34)
> >> On 9/5/21 4:04 PM, Stephen Boyd wrote:
> >>
> >> > +static int ath10k_snoc_modem_notify(struct notifier_block *nb,
> >> > +unsigned long
> > [...]
> >>
> >> > +
> >>
> >> > + return NOTIFY_OK;
> >>
> >> > +}
> >>
> >>
> >>
> >> Thanks for posting the patch. It would be preferable to use a
> >> different flag instead of ATH10K_SNOC_FLAG_UNREGISTERING,
> >>
> >> since we are not unloading the ath10k driver.
>
> Weird, I don't see pillair's email on patchwork[1] and not in the ath10k
list
> either. Was it sent as HTML or something?

Hi Kalle,
Yes, I replied via the "In-reply-to" from the patchworks[1] link.

Thanks,
Rakesh Pillai

>
> [1] https://patchwork.kernel.org/project/linux-
> wireless/patch/[email protected]/
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingp
> atches