2023-10-16 18:51:54

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics

On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote:
> The .probe() function would allocate the necessary space and ensure that
> the library call sizes the nunber of statistics but the callbacks
> necessary to fetch the name and values were not wired up.
>
> Reported-by: Justin Chen <[email protected]>
> Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165")
> Signed-off-by: Florian Fainelli <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2023-10-17 19:46:15

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics

On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote:
> The .probe() function would allocate the necessary space and ensure that
> the library call sizes the nunber of statistics but the callbacks
> necessary to fetch the name and values were not wired up.
>
> Reported-by: Justin Chen <[email protected]>
> Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165")

Should the fixes tag be as follows?

Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165")

> Signed-off-by: Florian Fainelli <[email protected]>

...

2023-10-17 20:38:08

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics

On 10/17/23 12:45, Simon Horman wrote:
> On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote:
>> The .probe() function would allocate the necessary space and ensure that
>> the library call sizes the nunber of statistics but the callbacks
>> necessary to fetch the name and values were not wired up.
>>
>> Reported-by: Justin Chen <[email protected]>
>> Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165")
>
> Should the fixes tag be as follows?
>
> Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165")

Yes it should, it looks like 1b89b3dce34c was from our downstream tree.
Let me re-submit with the correct Fixes tag then, thanks Simon!
--
Florian