With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific
cpufreq driver support"), the last specific Exynos-cpufreq driver
depending on ARM_EXYNOS_CPUFREQ was removed. As there is no
Exynos-specific cpufreq driver depending on the code in
drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ),
this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig.
After all, the rule in drivers/cpufreq/Makefile, to combine all
specific cpufreq drivers depending on the generic code for Exynos into
one objectfile is obsolete and can be removed.
Remove unselectable rule for arm-exynos-cpufreq.o from
drivers/cpufreq/Makefile, which - if selectable - would generate an
always empty objectfile.
Signed-off-by: Jonas Rabenstein <[email protected]>
---
I found this inconsistency using the undertaker and
undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
drivers/cpufreq/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index bbc4a9f..958be2b 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
-obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
--
2.5.0
On 13-08-15, 12:32, Jonas Rabenstein wrote:
> With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific
> cpufreq driver support"), the last specific Exynos-cpufreq driver
> depending on ARM_EXYNOS_CPUFREQ was removed. As there is no
> Exynos-specific cpufreq driver depending on the code in
> drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ),
> this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig.
> After all, the rule in drivers/cpufreq/Makefile, to combine all
> specific cpufreq drivers depending on the generic code for Exynos into
> one objectfile is obsolete and can be removed.
>
> Remove unselectable rule for arm-exynos-cpufreq.o from
> drivers/cpufreq/Makefile, which - if selectable - would generate an
> always empty objectfile.
>
> Signed-off-by: Jonas Rabenstein <[email protected]>
> ---
> I found this inconsistency using the undertaker and
> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>
> drivers/cpufreq/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index bbc4a9f..958be2b 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>
> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
Acked-by: Viresh Kumar <[email protected]>
--
viresh
2015-08-13 19:32 GMT+09:00 Jonas Rabenstein
<[email protected]>:
> With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific
> cpufreq driver support"), the last specific Exynos-cpufreq driver
> depending on ARM_EXYNOS_CPUFREQ was removed. As there is no
> Exynos-specific cpufreq driver depending on the code in
> drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ),
> this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig.
> After all, the rule in drivers/cpufreq/Makefile, to combine all
> specific cpufreq drivers depending on the generic code for Exynos into
> one objectfile is obsolete and can be removed.
>
> Remove unselectable rule for arm-exynos-cpufreq.o from
> drivers/cpufreq/Makefile, which - if selectable - would generate an
> always empty objectfile.
That's a lot, really a lot of words, just to say that
ARM_EXYNOS_CPUFREQ option was removed and we should get rid of any
left-overs. The patch is of course valid... but could you trim this to
a short sentence giving the reason? Mentioned commit ID comes from
linux-next (or maintainer branch which may rebase) so it won't work
long-term. I think you can just leave the title of the commit.
When re-spinning:
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Viresh,
Do you want this to go through samsung-soc tree?
Best regards,
Krzysztof
>
> Signed-off-by: Jonas Rabenstein <[email protected]>
> ---
> I found this inconsistency using the undertaker and
> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>
> drivers/cpufreq/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index bbc4a9f..958be2b 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>
> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On 13-08-15, 19:53, Krzysztof Kozlowski wrote:
> 2015-08-13 19:32 GMT+09:00 Jonas Rabenstein
> <[email protected]>:
> > With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific
> > cpufreq driver support"), the last specific Exynos-cpufreq driver
> > depending on ARM_EXYNOS_CPUFREQ was removed. As there is no
> > Exynos-specific cpufreq driver depending on the code in
> > drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ),
> > this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig.
> > After all, the rule in drivers/cpufreq/Makefile, to combine all
> > specific cpufreq drivers depending on the generic code for Exynos into
> > one objectfile is obsolete and can be removed.
> >
> > Remove unselectable rule for arm-exynos-cpufreq.o from
> > drivers/cpufreq/Makefile, which - if selectable - would generate an
> > always empty objectfile.
>
> That's a lot, really a lot of words, just to say that
> ARM_EXYNOS_CPUFREQ option was removed and we should get rid of any
> left-overs. The patch is of course valid... but could you trim this to
> a short sentence giving the reason? Mentioned commit ID comes from
> linux-next (or maintainer branch which may rebase) so it won't work
> long-term. I think you can just leave the title of the commit.
>
> When re-spinning:
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> Viresh,
> Do you want this to go through samsung-soc tree?
That's Rafael's call, but even he can't take it right now. This patch
has dependency on the samsung pull request. So it should go that way
only.
But if you are already late, then Rafael can apply this after 4.3-rc1
is out.
--
viresh
Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
in drivers/cpufreq/Makefile which depends on that option.
Remove unselectable rule for arm-exynos-cpufreq.o from
drivers/cpufreq/Makefile.
Signed-off-by: Jonas Rabenstein <[email protected]>
---
I found this inconsistency using the undertaker and
undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
drivers/cpufreq/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index bbc4a9f..958be2b 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
-obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
--
2.5.0
On 13-08-15, 13:28, Jonas Rabenstein wrote:
> Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
> support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
> in drivers/cpufreq/Makefile which depends on that option.
>
> Remove unselectable rule for arm-exynos-cpufreq.o from
> drivers/cpufreq/Makefile.
>
> Signed-off-by: Jonas Rabenstein <[email protected]>
> ---
> I found this inconsistency using the undertaker and
> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>
> drivers/cpufreq/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index bbc4a9f..958be2b 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>
> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
Acked-by: Viresh Kumar <[email protected]>
--
viresh
2015-08-13 20:33 GMT+09:00 Viresh Kumar <[email protected]>:
> On 13-08-15, 13:28, Jonas Rabenstein wrote:
>> Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
>> support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
>> in drivers/cpufreq/Makefile which depends on that option.
>>
>> Remove unselectable rule for arm-exynos-cpufreq.o from
>> drivers/cpufreq/Makefile.
>>
>> Signed-off-by: Jonas Rabenstein <[email protected]>
>> ---
>> I found this inconsistency using the undertaker and
>> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>>
>> drivers/cpufreq/Makefile | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
>> index bbc4a9f..958be2b 100644
>> --- a/drivers/cpufreq/Makefile
>> +++ b/drivers/cpufreq/Makefile
>> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>>
>> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
>> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
>> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
>> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
>> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
>> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
>
> Acked-by: Viresh Kumar <[email protected]>
And again from me:
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Dear Kukjin,
Can you take it and send in (updated) pull request with Exynos4x12
cpufreq patches?
BR,
Krzysztof
Krzysztof Kozlowski wrote:
>
> 2015-08-13 20:33 GMT+09:00 Viresh Kumar <[email protected]>:
> > On 13-08-15, 13:28, Jonas Rabenstein wrote:
> >> Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
> >> support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
> >> in drivers/cpufreq/Makefile which depends on that option.
> >>
> >> Remove unselectable rule for arm-exynos-cpufreq.o from
> >> drivers/cpufreq/Makefile.
> >>
> >> Signed-off-by: Jonas Rabenstein <[email protected]>
> >> ---
> >> I found this inconsistency using the undertaker and
> >> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
> >>
> >> drivers/cpufreq/Makefile | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> >> index bbc4a9f..958be2b 100644
> >> --- a/drivers/cpufreq/Makefile
> >> +++ b/drivers/cpufreq/Makefile
> >> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
> >>
> >> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> >> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> >> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
> >> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> >> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> >> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
> >
> > Acked-by: Viresh Kumar <[email protected]>
>
> And again from me:
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> Dear Kukjin,
> Can you take it and send in (updated) pull request with Exynos4x12
> cpufreq patches?
>
OK, sure. I'll take this.
Thanks,
Kukjin