On 01/12/17 00:06, Sebastian Reichel wrote:
>>>> How about let's call it a "typo fix" then? :)
>>>
>>> Well, it is not really a typo.
>>
>> Well what if the stable people pick it into earlier stable series
>> based on the word fix in the subject? That has happened before.
>>
>> I suggest you update the dts patches to use wording like
>> "update compatible to use new naming" or something similar.
>
> Patch 4/4 is a Fix and should be applied to stable trees. "omapdss,"
> prefix was never supposed to be in the DTS files, is not supposed to
> be in there now and will break some time in the future.
>
> Explanation: The early init of omapdss adds the prefix at runtime,
> so that the binding can use generic properties and the kernel can
> use omapdss specific drivers until the generic ones can be used
This is true, but the extra "omapdss" does not cause any issues at the
moment, and the time when it causes issues is still many kernel versions
in the future.
But, yes, thinking about this, I agree, it's better to pick this one
separately as a fix (after rebasing it on top of current maineline so
that it doesn't depend on the toppoly name change), and leaving the
toppoly->tpo change as a cleanup.
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Hi Tomi,
> Am 01.12.2017 um 09:13 schrieb Tomi Valkeinen <[email protected]>:
>
> On 01/12/17 00:06, Sebastian Reichel wrote:
>
>>>>> How about let's call it a "typo fix" then? :)
>>>>
>>>> Well, it is not really a typo.
>>>
>>> Well what if the stable people pick it into earlier stable series
>>> based on the word fix in the subject? That has happened before.
>>>
>>> I suggest you update the dts patches to use wording like
>>> "update compatible to use new naming" or something similar.
>>
>> Patch 4/4 is a Fix and should be applied to stable trees. "omapdss,"
>> prefix was never supposed to be in the DTS files, is not supposed to
>> be in there now and will break some time in the future.
>>
>> Explanation: The early init of omapdss adds the prefix at runtime,
>> so that the binding can use generic properties and the kernel can
>> use omapdss specific drivers until the generic ones can be used
>
> This is true, but the extra "omapdss" does not cause any issues at the
> moment, and the time when it causes issues is still many kernel versions
> in the future.
>
> But, yes, thinking about this, I agree, it's better to pick this one
> separately as a fix (after rebasing it on top of current maineline so
> that it doesn't depend on the toppoly name change), and leaving the
> toppoly->tpo change as a cleanup.
Just a note: there is no toppoly->tpo change for *this* panel and
Pandora board. Just omapdss removal.
The GTA04 needs a toppoly->tpo change but no omapdss, removal.
So they solve different problems and are independent of each other.
GTA04: change vendor string
Pandora: remove omapdss, prefix
BR and thanks,
Nikolaus
On 01/12/17 11:48, H. Nikolaus Schaller wrote:
> Just a note: there is no toppoly->tpo change for *this* panel and
> Pandora board. Just omapdss removal.
>
> The GTA04 needs a toppoly->tpo change but no omapdss, removal.
>
> So they solve different problems and are independent of each other.
>
> GTA04: change vendor string
> Pandora: remove omapdss, prefix
Oh, right, I totally missed that. I thought they were changes to the
same file...
In that case, Tony, can you pick this one as a fix? I'll pick the
toppoly->tpo patch and merge via drm tree, if you give the ack.
For this:
Acked-by: Tomi Valkeinen <[email protected]>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
* Tomi Valkeinen <[email protected]> [171201 02:03]:
> On 01/12/17 11:48, H. Nikolaus Schaller wrote:
>
> > Just a note: there is no toppoly->tpo change for *this* panel and
> > Pandora board. Just omapdss removal.
> >
> > The GTA04 needs a toppoly->tpo change but no omapdss, removal.
> >
> > So they solve different problems and are independent of each other.
> >
> > GTA04: change vendor string
> > Pandora: remove omapdss, prefix
>
> Oh, right, I totally missed that. I thought they were changes to the
> same file...
>
> In that case, Tony, can you pick this one as a fix? I'll pick the
> toppoly->tpo patch and merge via drm tree, if you give the ack.
>
> For this:
>
> Acked-by: Tomi Valkeinen <[email protected]>
Sorry I've lost track of this thread and what if anything is really
needed as a fix for v4.16. And now there's newer version of the two
dts patches in thread "[PATCH v4 0/2] Fixes for omapdrm on
OpenPandora and GTA04" so let's move the discussion there.
Regards,
Tony