2023-11-17 12:59:00

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] riscv: compat_vdso: align VDSOAS build log

Add one more space after "VDSOAS" for better alignment in the build log.

[Before]

LDS arch/riscv/kernel/compat_vdso/compat_vdso.lds
VDSOAS arch/riscv/kernel/compat_vdso/rt_sigreturn.o
VDSOAS arch/riscv/kernel/compat_vdso/getcpu.o
VDSOAS arch/riscv/kernel/compat_vdso/flush_icache.o
VDSOAS arch/riscv/kernel/compat_vdso/note.o
VDSOLD arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
VDSOSYM include/generated/compat_vdso-offsets.h

[After]

LDS arch/riscv/kernel/compat_vdso/compat_vdso.lds
VDSOAS arch/riscv/kernel/compat_vdso/rt_sigreturn.o
VDSOAS arch/riscv/kernel/compat_vdso/getcpu.o
VDSOAS arch/riscv/kernel/compat_vdso/flush_icache.o
VDSOAS arch/riscv/kernel/compat_vdso/note.o
VDSOLD arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
VDSOSYM include/generated/compat_vdso-offsets.h

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/riscv/kernel/compat_vdso/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/compat_vdso/Makefile b/arch/riscv/kernel/compat_vdso/Makefile
index 62fa393b2eb2..3df4cb788c1f 100644
--- a/arch/riscv/kernel/compat_vdso/Makefile
+++ b/arch/riscv/kernel/compat_vdso/Makefile
@@ -74,5 +74,5 @@ quiet_cmd_compat_vdsold = VDSOLD $@
rm [email protected]

# actual build commands
-quiet_cmd_compat_vdsoas = VDSOAS $@
+quiet_cmd_compat_vdsoas = VDSOAS $@
cmd_compat_vdsoas = $(COMPAT_CC) $(a_flags) $(COMPAT_CC_FLAGS) -c -o $@ $<
--
2.40.1


2024-03-06 20:01:40

by Alexandre Ghiti

[permalink] [raw]
Subject: Re: [PATCH] riscv: compat_vdso: align VDSOAS build log

Hi Masahiro,

On 17/11/2023 13:58, Masahiro Yamada wrote:
> Add one more space after "VDSOAS" for better alignment in the build log.
>
> [Before]
>
> LDS arch/riscv/kernel/compat_vdso/compat_vdso.lds
> VDSOAS arch/riscv/kernel/compat_vdso/rt_sigreturn.o
> VDSOAS arch/riscv/kernel/compat_vdso/getcpu.o
> VDSOAS arch/riscv/kernel/compat_vdso/flush_icache.o
> VDSOAS arch/riscv/kernel/compat_vdso/note.o
> VDSOLD arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
> VDSOSYM include/generated/compat_vdso-offsets.h
>
> [After]
>
> LDS arch/riscv/kernel/compat_vdso/compat_vdso.lds
> VDSOAS arch/riscv/kernel/compat_vdso/rt_sigreturn.o
> VDSOAS arch/riscv/kernel/compat_vdso/getcpu.o
> VDSOAS arch/riscv/kernel/compat_vdso/flush_icache.o
> VDSOAS arch/riscv/kernel/compat_vdso/note.o
> VDSOLD arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
> VDSOSYM include/generated/compat_vdso-offsets.h
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/riscv/kernel/compat_vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/compat_vdso/Makefile b/arch/riscv/kernel/compat_vdso/Makefile
> index 62fa393b2eb2..3df4cb788c1f 100644
> --- a/arch/riscv/kernel/compat_vdso/Makefile
> +++ b/arch/riscv/kernel/compat_vdso/Makefile
> @@ -74,5 +74,5 @@ quiet_cmd_compat_vdsold = VDSOLD $@
> rm [email protected]
>
> # actual build commands
> -quiet_cmd_compat_vdsoas = VDSOAS $@
> +quiet_cmd_compat_vdsoas = VDSOAS $@
> cmd_compat_vdsoas = $(COMPAT_CC) $(a_flags) $(COMPAT_CC_FLAGS) -c -o $@ $<


Reviewed-by: Alexandre Ghiti <[email protected]>

Thanks,

Alex


Subject: Re: [PATCH] riscv: compat_vdso: align VDSOAS build log

Hello:

This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <[email protected]>:

On Fri, 17 Nov 2023 21:58:43 +0900 you wrote:
> Add one more space after "VDSOAS" for better alignment in the build log.
>
> [Before]
>
> LDS arch/riscv/kernel/compat_vdso/compat_vdso.lds
> VDSOAS arch/riscv/kernel/compat_vdso/rt_sigreturn.o
> VDSOAS arch/riscv/kernel/compat_vdso/getcpu.o
> VDSOAS arch/riscv/kernel/compat_vdso/flush_icache.o
> VDSOAS arch/riscv/kernel/compat_vdso/note.o
> VDSOLD arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
> VDSOSYM include/generated/compat_vdso-offsets.h
>
> [...]

Here is the summary with links:
- riscv: compat_vdso: align VDSOAS build log
https://git.kernel.org/riscv/c/7115ff4a8bfe

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html