2024-01-30 06:04:31

by Yuan, Perry

Subject: [PATCH Resend 8/8] tools/power x86_energy_perf_policy: change intel msr functions to be static

change the intel_get_msr and intel_put_msr functions to be static.

No functional change intended.

Signed-off-by: Perry Yuan <[email protected]>
---
.../power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
index 845cfedab06e..a5f2f96fa383 100644
--- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
+++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
@@ -686,7 +686,7 @@ void err_on_hypervisor(void)
"not supported on this virtual machine");
}

-int intel_get_msr(int cpu, int offset, unsigned long long *msr)
+static int intel_get_msr(int cpu, int offset, unsigned long long *msr)
{
int retval;
char pathname[32];
@@ -710,7 +710,7 @@ int intel_get_msr(int cpu, int offset, unsigned long long *msr)
return 0;
}

-int intel_put_msr(int cpu, int offset, unsigned long long new_msr)
+static int intel_put_msr(int cpu, int offset, unsigned long long new_msr)
{
char pathname[32];
int retval;
--
2.34.1

2024-01-30 19:57:27

by Mario Limonciello

Subject: Re: [PATCH Resend 8/8] tools/power x86_energy_perf_policy: change intel msr functions to be static

On 1/29/2024 23:56, Perry Yuan wrote:
> change the intel_get_msr and intel_put_msr functions to be static.

Was this wrong from the beginning, or is it because of changes in your
series? You already have the "what" in the title. I think the "why"
should be described here.

>
> No functional change intended.
>
> Signed-off-by: Perry Yuan <[email protected]>
> ---
> .../power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> index 845cfedab06e..a5f2f96fa383 100644
> --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
> @@ -686,7 +686,7 @@ void err_on_hypervisor(void)
> "not supported on this virtual machine");
> }
>
> -int intel_get_msr(int cpu, int offset, unsigned long long *msr)
> +static int intel_get_msr(int cpu, int offset, unsigned long long *msr)
> {
> int retval;
> char pathname[32];
> @@ -710,7 +710,7 @@ int intel_get_msr(int cpu, int offset, unsigned long long *msr)
> return 0;
> }
>
> -int intel_put_msr(int cpu, int offset, unsigned long long new_msr)
> +static int intel_put_msr(int cpu, int offset, unsigned long long new_msr)
> {
> char pathname[32];
> int retval;