Don't shadow error from devm_extcon_dev_allocate() and return it as is.
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/extcon/extcon-intel-mrfld.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-intel-mrfld.c b/drivers/extcon/extcon-intel-mrfld.c
index 59cc3391bac7..2ee738f844ab 100644
--- a/drivers/extcon/extcon-intel-mrfld.c
+++ b/drivers/extcon/extcon-intel-mrfld.c
@@ -247,7 +247,7 @@ static int mrfld_extcon_probe(struct platform_device *pdev)
data->edev = devm_extcon_dev_allocate(dev, mrfld_extcon_cable);
if (IS_ERR(data->edev))
- return -ENOMEM;
+ return PTR_ERR(data->edev);
ret = devm_extcon_dev_register(dev, data->edev);
if (ret < 0) {
--
2.43.0.rc1.1.gbec44491f096
On Fri, Dec 22, 2023 at 06:18:54PM +0200, Andy Shevchenko wrote:
> Don't shadow error from devm_extcon_dev_allocate() and return it as is.
Any comment on this?
--
With Best Regards,
Andy Shevchenko
On Thu, Feb 08, 2024 at 09:24:58PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 22, 2023 at 06:18:54PM +0200, Andy Shevchenko wrote:
> > Don't shadow error from devm_extcon_dev_allocate() and return it as is.
>
> Any comment on this?
Here is another one, can it be applied as well?
--
With Best Regards,
Andy Shevchenko
> -----Original Message-----
> From: Andy Shevchenko <[email protected]>
> Sent: Thursday, February 22, 2024 10:18 PM
> To: [email protected]
> Cc: MyungJoo Ham <[email protected]>; Chanwoo Choi
> <[email protected]>
> Subject: Re: [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from
> devm_extcon_dev_allocate()
>
> On Thu, Feb 08, 2024 at 09:24:58PM +0200, Andy Shevchenko wrote:
> > On Fri, Dec 22, 2023 at 06:18:54PM +0200, Andy Shevchenko wrote:
> > > Don't shadow error from devm_extcon_dev_allocate() and return it as
is.
> >
> > Any comment on this?
>
> Here is another one, can it be applied as well?
Applied it. Thanks.
Best Regards,
Chanwoo Choi
On Fri, Feb 23, 2024 at 04:43:15PM +0900, Chanwoo Choi wrote:
> > From: Andy Shevchenko <[email protected]>
> > Sent: Thursday, February 22, 2024 10:18 PM
> > On Thu, Feb 08, 2024 at 09:24:58PM +0200, Andy Shevchenko wrote:
..
> > Here is another one, can it be applied as well?
>
> Applied it. Thanks.
Thank you!
--
With Best Regards,
Andy Shevchenko