2019-04-18 09:16:23

by Jan Kiszka

[permalink] [raw]
Subject: [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching

From: Su Bao Cheng <[email protected]>

Since there are more IOT2040 variants with identical hardware but
different asset tags, the asset tag matching should be adjusted to
support them.

For the board name "SIMATIC IOT2000", currently there are 2 types of
hardware, IOT2020 and IOT2040. Both are identical regarding the
intel_quark_i2c_gpio. In the future there will be no other devices with
the "SIMATIC IOT2000" DMI board name but different hardware. So remove
the asset tag matching from this driver.

Signed-off-by: Su Bao Cheng <[email protected]>
Reviewed-by: Jan Kiszka <[email protected]>
---
drivers/mfd/intel_quark_i2c_gpio.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
index 5bddb84cfc1f..11adbf77960d 100644
--- a/drivers/mfd/intel_quark_i2c_gpio.c
+++ b/drivers/mfd/intel_quark_i2c_gpio.c
@@ -74,16 +74,6 @@ static const struct dmi_system_id dmi_platform_info[] = {
{
.matches = {
DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
- DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
- "6ES7647-0AA00-0YA2"),
- },
- .driver_data = (void *)400000,
- },
- {
- .matches = {
- DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
- DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
- "6ES7647-0AA00-1YA2"),
},
.driver_data = (void *)400000,
},
--
2.16.4


2019-04-26 14:47:54

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching

On Thu, Apr 18, 2019 at 12:15 PM Jan Kiszka <[email protected]> wrote:
>
> From: Su Bao Cheng <[email protected]>
>
> Since there are more IOT2040 variants with identical hardware but
> different asset tags, the asset tag matching should be adjusted to
> support them.
>
> For the board name "SIMATIC IOT2000", currently there are 2 types of
> hardware, IOT2020 and IOT2040. Both are identical regarding the
> intel_quark_i2c_gpio. In the future there will be no other devices with
> the "SIMATIC IOT2000" DMI board name but different hardware. So remove
> the asset tag matching from this driver.
>

Acked-by: Andy Shevchenko <[email protected]>

> Signed-off-by: Su Bao Cheng <[email protected]>
> Reviewed-by: Jan Kiszka <[email protected]>
> ---
> drivers/mfd/intel_quark_i2c_gpio.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
> index 5bddb84cfc1f..11adbf77960d 100644
> --- a/drivers/mfd/intel_quark_i2c_gpio.c
> +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> @@ -74,16 +74,6 @@ static const struct dmi_system_id dmi_platform_info[] = {
> {
> .matches = {
> DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
> - DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
> - "6ES7647-0AA00-0YA2"),
> - },
> - .driver_data = (void *)400000,
> - },
> - {
> - .matches = {
> - DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
> - DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
> - "6ES7647-0AA00-1YA2"),
> },
> .driver_data = (void *)400000,
> },
> --
> 2.16.4



--
With Best Regards,
Andy Shevchenko

2019-05-08 10:36:55

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd: intel_quark_i2c_gpio: Adjust IOT2000 matching

On Thu, 18 Apr 2019, Jan Kiszka wrote:

> From: Su Bao Cheng <[email protected]>
>
> Since there are more IOT2040 variants with identical hardware but
> different asset tags, the asset tag matching should be adjusted to
> support them.
>
> For the board name "SIMATIC IOT2000", currently there are 2 types of
> hardware, IOT2020 and IOT2040. Both are identical regarding the
> intel_quark_i2c_gpio. In the future there will be no other devices with
> the "SIMATIC IOT2000" DMI board name but different hardware. So remove
> the asset tag matching from this driver.
>
> Signed-off-by: Su Bao Cheng <[email protected]>
> Reviewed-by: Jan Kiszka <[email protected]>
> ---
> drivers/mfd/intel_quark_i2c_gpio.c | 10 ----------
> 1 file changed, 10 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog