2017-06-29 11:29:38

by Arvind Yadav

[permalink] [raw]

Subject: [PATCH] PM: hibernate: constify attribute_group structures.

---

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
6332 488 308 7128 1bd8 kernel/power/hibernate.o

File size After adding 'const':
text data bss dec hex filename
6396 424 308 7128 1bd8 kernel/power/hibernate.o

Signed-off-by: Arvind Yadav <[email protected]>
---
kernel/power/hibernate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index a8b978c..e1914c7 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -1108,7 +1108,7 @@ static ssize_t reserved_size_store(struct kobject *kobj,
};


-static struct attribute_group attr_group = {
+static const struct attribute_group attr_group = {
.attrs = g,
};

--
1.9.1

2017-06-29 11:59:54

by Pavel Machek

[permalink] [raw]

Subject: Re: [PATCH] PM: hibernate: constify attribute_group structures.

---

On Thu 2017-06-29 16:58:40, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 6332 488 308 7128 1bd8 kernel/power/hibernate.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 6396 424 308 7128 1bd8 kernel/power/hibernate.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Acked-by: Pavel Machek <[email protected]>


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

---

Attachments:

(No filename) (789.00 B)
signature.asc (181.00 B)
Digital signature Download all attachments