commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
Update the help text to reflect that change: the frame pointer unwinder
is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
Signed-off-by: Joe Lawrence <[email protected]>
---
v2: dropped hunk that added unnecessary text to UNWIND_GUESS
arch/x86/Kconfig.debug | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index bf9cd83de777..409c00f74e60 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -316,10 +316,6 @@ config UNWINDER_FRAME_POINTER
unwinder, but the kernel text size will grow by ~3% and the kernel's
overall performance will degrade by roughly 5-10%.
- This option is recommended if you want to use the livepatch
- consistency model, as this is currently the only way to get a
- reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE).
-
config UNWINDER_GUESS
bool "Guess unwinder"
depends on EXPERT
--
2.21.0
On Wed, Nov 06, 2019 at 10:29:58PM -0500, Joe Lawrence wrote:
> commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> Update the help text to reflect that change: the frame pointer unwinder
> is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
>
> Signed-off-by: Joe Lawrence <[email protected]>
> ---
>
> v2: dropped hunk that added unnecessary text to UNWIND_GUESS
>
> arch/x86/Kconfig.debug | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index bf9cd83de777..409c00f74e60 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -316,10 +316,6 @@ config UNWINDER_FRAME_POINTER
> unwinder, but the kernel text size will grow by ~3% and the kernel's
> overall performance will degrade by roughly 5-10%.
>
> - This option is recommended if you want to use the livepatch
> - consistency model, as this is currently the only way to get a
> - reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE).
> -
> config UNWINDER_GUESS
> bool "Guess unwinder"
> depends on EXPERT
> --
> 2.21.0
>
Acked-by: Josh Poimboeuf <[email protected]>
--
Josh
On Wed, 6 Nov 2019, Joe Lawrence wrote:
> commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> Update the help text to reflect that change: the frame pointer unwinder
> is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
>
> Signed-off-by: Joe Lawrence <[email protected]>
Acked-by: Miroslav Benes <[email protected]>
M
On 11/7/19 8:59 AM, Joe Lawrence wrote:
> commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> Update the help text to reflect that change: the frame pointer unwinder
> is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
>
> Signed-off-by: Joe Lawrence <[email protected]>
Reviewed-by: Kamalesh Babulal <[email protected]>
--
Kamalesh
On Wed 2019-11-06 21:34:58, Josh Poimboeuf wrote:
> On Wed, Nov 06, 2019 at 10:29:58PM -0500, Joe Lawrence wrote:
> > commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> > for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> > Update the help text to reflect that change: the frame pointer unwinder
> > is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
> >
> > Signed-off-by: Joe Lawrence <[email protected]>
>
> Acked-by: Josh Poimboeuf <[email protected]>
It is committed in livepatch.git, branch for-5.5/core.
Best Regards,
Petr