2022-06-29 00:03:26

by Rob Clark

[permalink] [raw]
Subject: [PATCH] drm/i915: Remove __dma_fence_is_chain()

From: Rob Clark <[email protected]>

drive-by cleanup

Signed-off-by: Rob Clark <[email protected]>
---
drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
index 319936f91ac5..667841780514 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
@@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence,
rcu_read_unlock();
}

-static inline bool __dma_fence_is_chain(const struct dma_fence *fence)
-{
- return fence->ops == &dma_fence_chain_ops;
-}
-
void i915_gem_fence_wait_priority(struct dma_fence *fence,
const struct i915_sched_attr *attr)
{
@@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence,

for (i = 0; i < array->num_fences; i++)
fence_set_priority(array->fences[i], attr);
- } else if (__dma_fence_is_chain(fence)) {
+ } else if (dma_fence_is_chain(fence)) {
struct dma_fence *iter;

/* The chain is ordered; if we boost the last, we boost all */
--
2.36.1


Subject: Re: [Linaro-mm-sig] [PATCH] drm/i915: Remove __dma_fence_is_chain()


On 6/29/22 01:35, Rob Clark wrote:
> From: Rob Clark <[email protected]>
>
> drive-by cleanup
>
> Signed-off-by: Rob Clark <[email protected]>

Reviewed-by: Thomas Hellström <[email protected]>


> ---
> drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> index 319936f91ac5..667841780514 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence,
> rcu_read_unlock();
> }
>
> -static inline bool __dma_fence_is_chain(const struct dma_fence *fence)
> -{
> - return fence->ops == &dma_fence_chain_ops;
> -}
> -
> void i915_gem_fence_wait_priority(struct dma_fence *fence,
> const struct i915_sched_attr *attr)
> {
> @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence,
>
> for (i = 0; i < array->num_fences; i++)
> fence_set_priority(array->fences[i], attr);
> - } else if (__dma_fence_is_chain(fence)) {
> + } else if (dma_fence_is_chain(fence)) {
> struct dma_fence *iter;
>
> /* The chain is ordered; if we boost the last, we boost all */

2022-06-29 07:18:17

by Christian König

[permalink] [raw]
Subject: Re: [PATCH] drm/i915: Remove __dma_fence_is_chain()

Am 29.06.22 um 01:35 schrieb Rob Clark:
> From: Rob Clark <[email protected]>
>
> drive-by cleanup
>
> Signed-off-by: Rob Clark <[email protected]>

We should probably completely remove that dependency and rather use
dma_fence_unwrap instead.

But that's probably for another patch Reviewed-by: Christian König
<[email protected]>.

Christian.


> ---
> drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> index 319936f91ac5..667841780514 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence,
> rcu_read_unlock();
> }
>
> -static inline bool __dma_fence_is_chain(const struct dma_fence *fence)
> -{
> - return fence->ops == &dma_fence_chain_ops;
> -}
> -
> void i915_gem_fence_wait_priority(struct dma_fence *fence,
> const struct i915_sched_attr *attr)
> {
> @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence,
>
> for (i = 0; i < array->num_fences; i++)
> fence_set_priority(array->fences[i], attr);
> - } else if (__dma_fence_is_chain(fence)) {
> + } else if (dma_fence_is_chain(fence)) {
> struct dma_fence *iter;
>
> /* The chain is ordered; if we boost the last, we boost all */

2022-06-30 14:48:19

by Andrzej Hajda

[permalink] [raw]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain()

On 29.06.2022 01:35, Rob Clark wrote:
> From: Rob Clark <[email protected]>
>
> drive-by cleanup
>
> Signed-off-by: Rob Clark <[email protected]>

Reviewed-by: Andrzej Hajda <[email protected]>

Regards
Andrzej

> ---
> drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> index 319936f91ac5..667841780514 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c
> @@ -73,11 +73,6 @@ static void fence_set_priority(struct dma_fence *fence,
> rcu_read_unlock();
> }
>
> -static inline bool __dma_fence_is_chain(const struct dma_fence *fence)
> -{
> - return fence->ops == &dma_fence_chain_ops;
> -}
> -
> void i915_gem_fence_wait_priority(struct dma_fence *fence,
> const struct i915_sched_attr *attr)
> {
> @@ -93,7 +88,7 @@ void i915_gem_fence_wait_priority(struct dma_fence *fence,
>
> for (i = 0; i < array->num_fences; i++)
> fence_set_priority(array->fences[i], attr);
> - } else if (__dma_fence_is_chain(fence)) {
> + } else if (dma_fence_is_chain(fence)) {
> struct dma_fence *iter;
>
> /* The chain is ordered; if we boost the last, we boost all */