Update the compatible string to add new device tree binding
CC: [email protected]
Signed-off-by: Matthew McClintock <[email protected]>
---
Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
index 60bb2f98..45b37cf 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
@@ -6,6 +6,7 @@ Required properties :
"qcom,kpss-timer"
"qcom,scss-timer"
+ "qcom,kpss-standalone"
- reg : shall contain base register location and length
- clocks : shall contain the input clock
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote:
> Update the compatible string to add new device tree binding
>
> CC: [email protected]
> Signed-off-by: Matthew McClintock <[email protected]>
> ---
> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> index 60bb2f98..45b37cf 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> @@ -6,6 +6,7 @@ Required properties :
>
> "qcom,kpss-timer"
> "qcom,scss-timer"
> + "qcom,kpss-standalone"
What SoC(s) is this in. Use SoC specific compatible strings please.
Rob
On Mar 25, 2016, at 9:15 AM, Rob Herring <[email protected]> wrote:
>
> On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote:
>> Update the compatible string to add new device tree binding
>>
>> CC: [email protected]
>> Signed-off-by: Matthew McClintock <[email protected]>
>> ---
>> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> index 60bb2f98..45b37cf 100644
>> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> @@ -6,6 +6,7 @@ Required properties :
>>
>> "qcom,kpss-timer"
>> "qcom,scss-timer"
>> + "qcom,kpss-standalone"
>
> What SoC(s) is this in. Use SoC specific compatible strings please.
So ipq4019 wins the race because we are the first to try to enable watchdog for this block?
qcom,kpss-ipq4019 ?
-M
On Mon, Mar 28, 2016 at 12:02 PM, Matthew McClintock
<[email protected]> wrote:
> On Mar 25, 2016, at 9:15 AM, Rob Herring <[email protected]> wrote:
>>
>> On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote:
>>> Update the compatible string to add new device tree binding
>>>
>>> CC: [email protected]
>>> Signed-off-by: Matthew McClintock <[email protected]>
>>> ---
>>> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>>> index 60bb2f98..45b37cf 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>>> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>>> @@ -6,6 +6,7 @@ Required properties :
>>>
>>> "qcom,kpss-timer"
>>> "qcom,scss-timer"
>>> + "qcom,kpss-standalone"
>>
>> What SoC(s) is this in. Use SoC specific compatible strings please.
>
> So ipq4019 wins the race because we are the first to try to enable watchdog for this block?
Yep, that's how it is supposed to work. Newer chips claim
compatibility with older ones.
> qcom,kpss-ipq4019 ?
Yes, but generally <vendor>,<soc>-<block> is preferred order.
Rob
On Mon, Mar 28, 2016 at 12:02:47PM -0500, Matthew McClintock wrote:
> On Mar 25, 2016, at 9:15 AM, Rob Herring <[email protected]> wrote:
> >
> > On Wed, Mar 23, 2016 at 05:05:04PM -0500, Matthew McClintock wrote:
> >> Update the compatible string to add new device tree binding
> >>
> >> CC: [email protected]
> >> Signed-off-by: Matthew McClintock <[email protected]>
> >> ---
> >> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> >> index 60bb2f98..45b37cf 100644
> >> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> >> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> >> @@ -6,6 +6,7 @@ Required properties :
> >>
> >> "qcom,kpss-timer"
> >> "qcom,scss-timer"
> >> + "qcom,kpss-standalone"
> >
> > What SoC(s) is this in. Use SoC specific compatible strings please.
>
> So ipq4019 wins the race because we are the first to try to enable watchdog for this block?
>
> qcom,kpss-ipq4019 ?
>
It is a dedicated watchdog block, isn't it ? "qcom,kpss-ipq4019" would not
refer to a specific block. Devicetree maintainers may have a better idea,
but it seems to me that there should be 'wdt' or 'watchdog' in the property
name.
Guenter
On Mar 28, 2016, at 1:15 PM, Guenter Roeck <[email protected]> wrote:
>
>>> What SoC(s) is this in. Use SoC specific compatible strings please.
>>
>> So ipq4019 wins the race because we are the first to try to enable watchdog for this block?
>>
>> qcom,kpss-ipq4019 ?
>>
> It is a dedicated watchdog block, isn't it ? "qcom,kpss-ipq4019" would not
> refer to a specific block. Devicetree maintainers may have a better idea,
> but it seems to me that there should be 'wdt' or 'watchdog' in the property
> name.
Sounds fine to me, if no one has any other comments I’ll use this one in the next spin of the patch.
-M