2022-05-07 17:08:40

by Phil Auld

[permalink] [raw]
Subject: Re: [PATCH] docs: sched: Update sched-rt-group Documentation For Gender Inclusiveness

On Wed, May 04, 2022 at 10:14:24PM -0400 Joseph Salisbury wrote:
> Document assumes root user is he:
> "assumes root knows what he is doing."
>
> Update documentation for inclusivness, since root is not limited by gender.
>
> Fixes: 60aa605dfce2 ("sched: rt: document the risk of small values in the bandwidth settings")
> Cc: [email protected]
> Signed-off-by: Joseph Salisbury <[email protected]>
> ---
> Documentation/scheduler/sched-rt-group.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/scheduler/sched-rt-group.rst b/Documentation/scheduler/sched-rt-group.rst
> index 655a096ec8fb..e55fee6772c4 100644
> --- a/Documentation/scheduler/sched-rt-group.rst
> +++ b/Documentation/scheduler/sched-rt-group.rst
> @@ -19,7 +19,7 @@ Real-Time group scheduling
> ==========
>
> Fiddling with these settings can result in an unstable system, the knobs are
> - root only and assumes root knows what he is doing.
> + root only and assumes root knows what they are doing.
>

Now there's a singular vs plural problem.

"... assumes root users know ..." ?



Cheers,
Phil

> Most notable:
>
> --
> 2.34.1
>

--



2022-05-09 05:38:46

by Joseph Salisbury

[permalink] [raw]
Subject: Re: [PATCH] docs: sched: Update sched-rt-group Documentation For Gender Inclusiveness



On 5/6/22 10:29, Phil Auld wrote:
> On Wed, May 04, 2022 at 10:14:24PM -0400 Joseph Salisbury wrote:
>> Document assumes root user is he:
>> "assumes root knows what he is doing."
>>
>> Update documentation for inclusivness, since root is not limited by gender.
>>
>> Fixes: 60aa605dfce2 ("sched: rt: document the risk of small values in the bandwidth settings")
>> Cc: [email protected]
>> Signed-off-by: Joseph Salisbury <[email protected]>
>> ---
>> Documentation/scheduler/sched-rt-group.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/scheduler/sched-rt-group.rst b/Documentation/scheduler/sched-rt-group.rst
>> index 655a096ec8fb..e55fee6772c4 100644
>> --- a/Documentation/scheduler/sched-rt-group.rst
>> +++ b/Documentation/scheduler/sched-rt-group.rst
>> @@ -19,7 +19,7 @@ Real-Time group scheduling
>> ==========
>>
>> Fiddling with these settings can result in an unstable system, the knobs are
>> - root only and assumes root knows what he is doing.
>> + root only and assumes root knows what they are doing.
>>
> Now there's a singular vs plural problem.
>
> "... assumes root users know ..." ?
Thanks for the feedback, Phil.

Your suggestion makes more sense.  I'll wait for any additional
responses before sending a v2 with your suggestion.
>
>
>
> Cheers,
> Phil
>
>> Most notable:
>>
>> --
>> 2.34.1
>>