2020-01-16 14:16:06

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] usb: gadget: xudc: Remove redundant platform_get_irq error message

platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
index 634c2c1..fc1eafc 100644
--- a/drivers/usb/gadget/udc/tegra-xudc.c
+++ b/drivers/usb/gadget/udc/tegra-xudc.c
@@ -3492,11 +3492,8 @@ static int tegra_xudc_probe(struct platform_device *pdev)
}

xudc->irq = platform_get_irq(pdev, 0);
- if (xudc->irq < 0) {
- dev_err(xudc->dev, "failed to get IRQ: %d\n",
- xudc->irq);
+ if (xudc->irq < 0)
return xudc->irq;
- }

err = devm_request_irq(&pdev->dev, xudc->irq, tegra_xudc_irq, 0,
dev_name(&pdev->dev), xudc);
--
2.7.4



2020-01-17 04:20:32

by Nagarjuna Kristam

[permalink] [raw]
Subject: Re: [PATCH -next] usb: gadget: xudc: Remove redundant platform_get_irq error message

Reviewed-by: Nagarjuna Kristam <[email protected]>

On 16-01-2020 19:44, YueHaibing wrote:
> External email: Use caution opening links or attachments
>
>
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
> index 634c2c1..fc1eafc 100644
> --- a/drivers/usb/gadget/udc/tegra-xudc.c
> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
> @@ -3492,11 +3492,8 @@ static int tegra_xudc_probe(struct platform_device *pdev)
> }
>
> xudc->irq = platform_get_irq(pdev, 0);
> - if (xudc->irq < 0) {
> - dev_err(xudc->dev, "failed to get IRQ: %d\n",
> - xudc->irq);
> + if (xudc->irq < 0)
> return xudc->irq;
> - }
>
> err = devm_request_irq(&pdev->dev, xudc->irq, tegra_xudc_irq, 0,
> dev_name(&pdev->dev), xudc);
> --
> 2.7.4
>
>

2020-01-17 11:46:02

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH -next] usb: gadget: xudc: Remove redundant platform_get_irq error message

On Thu, Jan 16, 2020 at 10:14:33PM +0800, YueHaibing wrote:
> platform_get_irq() will call dev_err() itself on failure,
> so there is no need for the driver to also do this.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)

Acked-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (426.00 B)
 signature.asc (849.00 B)
 Download all attachments