2017-06-20 05:06:15

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] drm: sti: sti_hqvdp: make of_device_ids const.

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
15845 640 0 16485 4065 drivers/gpu/drm/sti/sti_hqvdp.o

File size after constify hqvdp_of_match:
text data bss dec hex filename
16229 224 0 16453 4045 drivers/gpu/drm/sti/sti_hqvdp.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index 267d816..075802d 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -1396,7 +1396,7 @@ static int sti_hqvdp_remove(struct platform_device *pdev)
return 0;
}

-static struct of_device_id hqvdp_of_match[] = {
+static const struct of_device_id hqvdp_of_match[] = {
{ .compatible = "st,stih407-hqvdp", },
{ /* end node */ }
};
--
1.9.1


2017-06-20 11:28:23

by Benjamin Gaignard

[permalink] [raw]
Subject: Re: [PATCH] drm: sti: sti_hqvdp: make of_device_ids const.

2017-06-20 7:05 GMT+02:00 Arvind Yadav <[email protected]>:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 15845 640 0 16485 4065 drivers/gpu/drm/sti/sti_hqvdp.o
>
> File size after constify hqvdp_of_match:
> text data bss dec hex filename
> 16229 224 0 16453 4045 drivers/gpu/drm/sti/sti_hqvdp.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied on drm-misc-next, thanks

> ---
> drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index 267d816..075802d 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -1396,7 +1396,7 @@ static int sti_hqvdp_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static struct of_device_id hqvdp_of_match[] = {
> +static const struct of_device_id hqvdp_of_match[] = {
> { .compatible = "st,stih407-hqvdp", },
> { /* end node */ }
> };
> --
> 1.9.1
>