2021-10-18 03:12:16

by Aleksander Jan Bajkowski

Subject: [PATCH net] net: dsa: lantiq_gswip: fix register definition

I compared the register definitions with the D-Link DWR-966
GPL sources and found that the PUAFD field definition was
incorrect. This definition is unused and causes no issues.

Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Aleksander Jan Bajkowski <[email protected]>
---
drivers/net/dsa/lantiq_gswip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 3ff4b7e177f3..dbd4486a173f 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -230,7 +230,7 @@
#define GSWIP_SDMA_PCTRLp(p) (0xBC0 + ((p) * 0x6))
#define GSWIP_SDMA_PCTRL_EN BIT(0) /* SDMA Port Enable */
#define GSWIP_SDMA_PCTRL_FCEN BIT(1) /* Flow Control Enable */
-#define GSWIP_SDMA_PCTRL_PAUFWD BIT(1) /* Pause Frame Forwarding */
+#define GSWIP_SDMA_PCTRL_PAUFWD BIT(3) /* Pause Frame Forwarding */

#define GSWIP_TABLE_ACTIVE_VLAN 0x01
#define GSWIP_TABLE_VLAN_MAPPING 0x02
--
2.30.2

2021-10-18 03:35:31

by Hauke Mehrtens

Subject: Re: [PATCH net] net: dsa: lantiq_gswip: fix register definition

On 10/16/21 12:10 AM, Aleksander Jan Bajkowski wrote:
> I compared the register definitions with the D-Link DWR-966
> GPL sources and found that the PUAFD field definition was
> incorrect. This definition is unused and causes no issues.
>
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Aleksander Jan Bajkowski <[email protected]>

Acked-by: Hauke Mehrtens <[email protected]>

Thanks for finding this problem.

> ---
> drivers/net/dsa/lantiq_gswip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 3ff4b7e177f3..dbd4486a173f 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -230,7 +230,7 @@
> #define GSWIP_SDMA_PCTRLp(p) (0xBC0 + ((p) * 0x6))
> #define GSWIP_SDMA_PCTRL_EN BIT(0) /* SDMA Port Enable */
> #define GSWIP_SDMA_PCTRL_FCEN BIT(1) /* Flow Control Enable */
> -#define GSWIP_SDMA_PCTRL_PAUFWD BIT(1) /* Pause Frame Forwarding */
> +#define GSWIP_SDMA_PCTRL_PAUFWD BIT(3) /* Pause Frame Forwarding */
>
> #define GSWIP_TABLE_ACTIVE_VLAN 0x01
> #define GSWIP_TABLE_VLAN_MAPPING 0x02
>

2021-10-18 12:41:24

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net: dsa: lantiq_gswip: fix register definition

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Sat, 16 Oct 2021 00:10:20 +0200 you wrote:
> I compared the register definitions with the D-Link DWR-966
> GPL sources and found that the PUAFD field definition was
> incorrect. This definition is unused and causes no issues.
>
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Aleksander Jan Bajkowski <[email protected]>
>
> [...]

Here is the summary with links:
- [net] net: dsa: lantiq_gswip: fix register definition
https://git.kernel.org/netdev/net/c/66d262804a22

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html