On 11/07/2017 10:24 PM, Lei Yang wrote:
> In next branch, Various build failed with:
>
> In file included from membarrier_test.c:8:0:
> ../kselftest.h: In function ‘ksft_print_header’:
> ../kselftest.h:61:3: error: expected ‘)’ before ‘printf’
> printf("TAP version 13\n");
> ^
> ../kselftest.h:62:1: error: expected expression before ‘}’ token
> }
> ^
>
> Signed-off-by: Lei Yang <[email protected]>
> ---
> tools/testing/selftests/kselftest.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index d6732ba312ef..acc98a5c3d73 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -57,7 +57,7 @@ static inline int ksft_get_error_cnt(void) { return ksft_cnt.ksft_error; }
>
> static inline void ksft_print_header(void)
> {
> - if (!(getenv("KSFT_TAP_LEVEL"))
> + if (!(getenv("KSFT_TAP_LEVEL")))
> printf("TAP version 13\n");
> }
>
>
Thanks for the patch. It was a mistake that the original patch
ended up in the linux-kselftest next branch. My bad. I ended up
committing the patch my mistake. It is now removed.
thanks,
-- Shuah
From 1583483204746654793@xxx Wed Nov 08 07:47:42 +0000 2017
X-GM-THRID: 1583483204746654793
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread