2023-04-20 02:08:48

by Tom Rix

Subject: [PATCH] drm/amd/display: remove unused variables otg_inst and cmd

gcc reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:
In function ‘dcn21_set_backlight_level’:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:229:18:
error: unused variable ‘otg_inst’ [-Werror=unused-variable]
229 | uint32_t otg_inst = pipe_ctx->stream_res.tg->inst;
| ^~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:226:27:
error: unused variable ‘cmd’ [-Werror=unused-variable]
226 | union dmub_rb_cmd cmd;
| ^~~

These variables are not used, so remove them.

Fixes: e97cc04fe0fb ("drm/amd/display: refactor dmub commands into single function")
Signed-off-by: Tom Rix <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
index 55a464a39529..43463d08f21b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
@@ -223,10 +223,8 @@ bool dcn21_set_backlight_level(struct pipe_ctx *pipe_ctx,
uint32_t backlight_pwm_u16_16,
uint32_t frame_ramp)
{
- union dmub_rb_cmd cmd;
struct dc_context *dc = pipe_ctx->stream->ctx;
struct abm *abm = pipe_ctx->stream_res.abm;
- uint32_t otg_inst = pipe_ctx->stream_res.tg->inst;
struct panel_cntl *panel_cntl = pipe_ctx->stream->link->panel_cntl;

if (dc->dc->res_pool->dmcu) {
--
2.27.0

2023-04-20 14:21:32

by Hamza Mahfooz

Subject: Re: [PATCH] drm/amd/display: remove unused variables otg_inst and cmd

On 4/19/23 22:04, Tom Rix wrote:
> gcc reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:
> In function ‘dcn21_set_backlight_level’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:229:18:
> error: unused variable ‘otg_inst’ [-Werror=unused-variable]
> 229 | uint32_t otg_inst = pipe_ctx->stream_res.tg->inst;
> | ^~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:226:27:
> error: unused variable ‘cmd’ [-Werror=unused-variable]
> 226 | union dmub_rb_cmd cmd;
> | ^~~
>
> These variables are not used, so remove them.
>
> Fixes: e97cc04fe0fb ("drm/amd/display: refactor dmub commands into single function")
> Signed-off-by: Tom Rix <[email protected]>

This has already been fixed, as of commit 1adb4dd5bd4b
("drm/amd/display: Remove unused variables in dcn21_hwseq.c") in
amd-staging-drm-next.

> ---
> drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
> index 55a464a39529..43463d08f21b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c
> @@ -223,10 +223,8 @@ bool dcn21_set_backlight_level(struct pipe_ctx *pipe_ctx,
> uint32_t backlight_pwm_u16_16,
> uint32_t frame_ramp)
> {
> - union dmub_rb_cmd cmd;
> struct dc_context *dc = pipe_ctx->stream->ctx;
> struct abm *abm = pipe_ctx->stream_res.abm;
> - uint32_t otg_inst = pipe_ctx->stream_res.tg->inst;
> struct panel_cntl *panel_cntl = pipe_ctx->stream->link->panel_cntl;
>
> if (dc->dc->res_pool->dmcu) {
--
Hamza