2021-03-21 19:14:43

by Jyri Sarha

[permalink] [raw]
Subject: Re: [PATCH] drm/tilcdc: panel: fix platform_no_drv_owner.cocci warnings

On 2021-03-03 11:04, Yang Li wrote:
> ./drivers/gpu/drm/tilcdc/tilcdc_panel.c:402:3-8: No need to set .owner
> here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Jyri Sarha <[email protected]>

I'll merge this soon to drm-misc-next.

Best regards,
Jyri

> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 00efc30..4235780 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -399,7 +399,6 @@ static int panel_remove(struct platform_device
> *pdev)
> .probe = panel_probe,
> .remove = panel_remove,
> .driver = {
> - .owner = THIS_MODULE,
> .name = "tilcdc-panel",
> .of_match_table = panel_of_match,
> },