2020-10-13 19:42:39

by Richard Sailer

[permalink] [raw]
Subject: Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

On 13/10/2020 19:18, Kleber Sacilotto de Souza wrote:
> From: Thadeu Lima de Souza Cascardo <[email protected]>
>
> When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason
> del_timer_sync can't be used is because this relies on keeping a reference
> to struct sock. But as we keep a pointer to dccps_hc_tx_ccid and free that
> during disconnect, the timer should really belong to struct dccp_sock.
>
> This addresses CVE-2020-16119.
>
> Fixes: 839a6094140a (net: dccp: Convert timers to use timer_setup())
> Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
> Signed-off-by: Kleber Sacilotto de Souza <[email protected]>

Acked-bd: Richard Sailer <[email protected]>

Implementation and concept looks fine to me


Attachments:
signature.asc (499.00 B)
OpenPGP digital signature