2022-11-07 14:47:46

by Bilbao, Carlos

Subject: [PATCH] drm/amd/display: Amend descriptions within enum pipe_split_policy

Correct descriptions of two last fields of enum pipe_split_policy, updating
comments with proper field names.

Signed-off-by: Carlos Bilbao <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dc.h | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index bfc5474c0f4c..277631a899d8 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -457,15 +457,16 @@ enum pipe_split_policy {
MPC_SPLIT_DYNAMIC = 0,

/**
- * @MPC_SPLIT_DYNAMIC: Avoid pipe split, which means that DC will not
+ * @MPC_SPLIT_AVOID: Avoid pipe split, which means that DC will not
* try any sort of split optimization.
*/
MPC_SPLIT_AVOID = 1,

/**
- * @MPC_SPLIT_DYNAMIC: With this option, DC will only try to optimize
- * the pipe utilization when using a single display; if the user
- * connects to a second display, DC will avoid pipe split.
+ * @MPC_SPLIT_AVOID_MULT_DISP: With this option, DC will only try
+ * to optimize the pipe utilization when using a single display;
+ * if the user connects to a second display, DC will avoid pipe
+ * split.
*/
MPC_SPLIT_AVOID_MULT_DISP = 2,
};
--
2.34.1

2022-11-08 17:27:44

by Alex Deucher

Subject: Re: [PATCH] drm/amd/display: Amend descriptions within enum pipe_split_policy

On Mon, Nov 7, 2022 at 9:37 AM Carlos Bilbao <[email protected]> wrote:
>
> Correct descriptions of two last fields of enum pipe_split_policy, updating
> comments with proper field names.
>
> Signed-off-by: Carlos Bilbao <[email protected]>

Acked-by: Alex Deucher <[email protected]>

> ---
> drivers/gpu/drm/amd/display/dc/dc.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index bfc5474c0f4c..277631a899d8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -457,15 +457,16 @@ enum pipe_split_policy {
> MPC_SPLIT_DYNAMIC = 0,
>
> /**
> - * @MPC_SPLIT_DYNAMIC: Avoid pipe split, which means that DC will not
> + * @MPC_SPLIT_AVOID: Avoid pipe split, which means that DC will not
> * try any sort of split optimization.
> */
> MPC_SPLIT_AVOID = 1,
>
> /**
> - * @MPC_SPLIT_DYNAMIC: With this option, DC will only try to optimize
> - * the pipe utilization when using a single display; if the user
> - * connects to a second display, DC will avoid pipe split.
> + * @MPC_SPLIT_AVOID_MULT_DISP: With this option, DC will only try
> + * to optimize the pipe utilization when using a single display;
> + * if the user connects to a second display, DC will avoid pipe
> + * split.
> */
> MPC_SPLIT_AVOID_MULT_DISP = 2,
> };
> --
> 2.34.1
>

2022-11-08 19:55:42

by Harry Wentland

Subject: Re: [PATCH] drm/amd/display: Amend descriptions within enum pipe_split_policy

On 11/7/22 09:37, Carlos Bilbao wrote:
> Correct descriptions of two last fields of enum pipe_split_policy, updating
> comments with proper field names.
>
> Signed-off-by: Carlos Bilbao <[email protected]>

Reviewed-by: Harry Wentland <[email protected]>

Harry

> ---
> drivers/gpu/drm/amd/display/dc/dc.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index bfc5474c0f4c..277631a899d8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -457,15 +457,16 @@ enum pipe_split_policy {
> MPC_SPLIT_DYNAMIC = 0,
>
> /**
> - * @MPC_SPLIT_DYNAMIC: Avoid pipe split, which means that DC will not
> + * @MPC_SPLIT_AVOID: Avoid pipe split, which means that DC will not
> * try any sort of split optimization.
> */
> MPC_SPLIT_AVOID = 1,
>
> /**
> - * @MPC_SPLIT_DYNAMIC: With this option, DC will only try to optimize
> - * the pipe utilization when using a single display; if the user
> - * connects to a second display, DC will avoid pipe split.
> + * @MPC_SPLIT_AVOID_MULT_DISP: With this option, DC will only try
> + * to optimize the pipe utilization when using a single display;
> + * if the user connects to a second display, DC will avoid pipe
> + * split.
> */
> MPC_SPLIT_AVOID_MULT_DISP = 2,
> };