It seems this is a copy-paste error and that the proper variable to use
in this particular case is _src_ instead of _dst_.
Addresses-Coverity-ID: 1465282 ("Copy-paste error")
Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index 4955ce3..58be99e 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -2763,7 +2763,7 @@ static int i40evf_parse_cls_flower(struct i40evf_adapter *adapter,
if (key->src) {
filter->f.mask.tcp_spec.src_port |= cpu_to_be16(0xffff);
- filter->f.data.tcp_spec.src_port = key->dst;
+ filter->f.data.tcp_spec.src_port = key->src;
}
}
filter->f.field_flags = field_flags;
--
2.7.4
On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
> It seems this is a copy-paste error and that the proper variable to
> use
> in this particular case is _src_ instead of _dst_.
>
> Addresses-Coverity-ID: 1465282 ("Copy-paste error")
> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
Thanks for the patch!
Acked-by:Harshitha Ramamurthy <[email protected]>
> ---
> drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> index 4955ce3..58be99e 100644
> --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> @@ -2763,7 +2763,7 @@ static int i40evf_parse_cls_flower(struct
> i40evf_adapter *adapter,
>
> if (key->src) {
> filter->f.mask.tcp_spec.src_port |=
> cpu_to_be16(0xffff);
> - filter->f.data.tcp_spec.src_port = key->dst;
> + filter->f.data.tcp_spec.src_port = key->src;
> }
> }
> filter->f.field_flags = field_flags;
On Thu, 2018-02-15 at 09:56 -0800, Ramamurthy, Harshitha wrote:
> On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
> > It seems this is a copy-paste error and that the proper variable to
> > use
> > in this particular case is _src_ instead of _dst_.
> >
> > Addresses-Coverity-ID: 1465282 ("Copy-paste error")
> > Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
> > Signed-off-by: Gustavo A. R. Silva <[email protected]>
>
> Thanks for the patch!
>
> Acked-by:Harshitha Ramamurthy <[email protected]>
Acked-by: Jeff Kirsher <[email protected]>
Dave, no need for me to pick this patch up and then push to you. You
can circumvent me and pick this up.
> > ---
> > drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
On 02/15/2018 12:11 PM, Jeff Kirsher wrote:
> On Thu, 2018-02-15 at 09:56 -0800, Ramamurthy, Harshitha wrote:
>> On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
>>> It seems this is a copy-paste error and that the proper variable to
>>> use
>>> in this particular case is _src_ instead of _dst_.
>>>
>>> Addresses-Coverity-ID: 1465282 ("Copy-paste error")
>>> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
>>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>>
>> Thanks for the patch!
>>
Glad to help. :)
>> Acked-by:Harshitha Ramamurthy <[email protected]>
>
> Acked-by: Jeff Kirsher <[email protected]>
>
> Dave, no need for me to pick this patch up and then push to you. You
> can circumvent me and pick this up.
>
>>> ---
>>> drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks guys.
--
Gustavo