2004-03-31 20:38:10

by John Rose

Subject: [PATCH] RPA PCI Hotplug - redundant free

Hi Greg-

Apologies for the resend, messed up the lkml address. Please commit the
following patch, which removes a redundant call to a
cleanup function from an error path of the module init code.

Thanks-
John

diff -Nru a/drivers/pci/hotplug/rpaphp_pci.c b/drivers/pci/hotplug/rpaphp_pci.c
--- a/drivers/pci/hotplug/rpaphp_pci.c Tue Mar 30 18:50:32 2004
+++ b/drivers/pci/hotplug/rpaphp_pci.c Tue Mar 30 18:50:32 2004
@@ -304,7 +304,6 @@
if (slot->hotplug_slot->info->adapter_status == NOT_VALID) {
dbg("%s: NOT_VALID: skip dn->full_name=%s\n",
__FUNCTION__, slot->dn->full_name);
- dealloc_slot_struct(slot);
return (-1);
}
return (0);

2004-03-31 23:34:38

by Greg KH

Subject: Re: [PATCH] RPA PCI Hotplug - redundant free

On Wed, Mar 31, 2004 at 02:39:04PM -0600, John Rose wrote:
> Hi Greg-
>
> Apologies for the resend, messed up the lkml address. Please commit the
> following patch, which removes a redundant call to a
> cleanup function from an error path of the module init code.

Applied, thanks.

greg k-h