Andrew,
Here is a patch setting s_dirt for read-write filesystems in ext3_init
(doing it in create_journal seems troublesome IMHO).
PS: untested
Regards,
FabF
FabF <[email protected]> wrote:
>
> Here is a patch setting s_dirt for read-write filesystems in ext3_init
> (doing it in create_journal seems troublesome IMHO).
Why?
> PS: untested
Please don't send untested patches.
> diff -Naur orig/fs/super.c edited/fs/super.c
> --- orig/fs/super.c 2004-06-16 07:20:03.000000000 +0200
> +++ edited/fs/super.c 2004-06-19 19:58:19.895637880 +0200
fs/super.c does not contain ext3 code.
On Sat, 2004-06-19 at 20:54, Andrew Morton wrote:
> FabF <[email protected]> wrote:
> >
> > Here is a patch setting s_dirt for read-write filesystems in ext3_init
> > (doing it in create_journal seems troublesome IMHO).
>
> Why?
ext3_create_journal is called with journal_inum parser option set which
means unjournaled r/w ext3 fs are s_dirt 0.
>
> > PS: untested
>
> Please don't send untested patches.
Ok, tested.No problem here.
On Sat, 2004-06-19 at 21:32, FabF wrote:
> On Sat, 2004-06-19 at 20:54, Andrew Morton wrote:
> > FabF <[email protected]> wrote:
> > >
> > > Here is a patch setting s_dirt for read-write filesystems in ext3_init
> > > (doing it in create_journal seems troublesome IMHO).
> >
> > Why?
> ext3_create_journal is called with journal_inum parser option set which
> means unjournaled r/w ext3 fs are s_dirt 0.
Oops ... ^has_journal is only ext2 readable so there's no problem at
that point ...Anyway, valid ext3 partition can be initialized with
load_journal or create_journal so s_dirt problem remains IMHO...
Regards,
FabF