2022-11-06 15:52:09

by KaiLong Wang

Subject: [PATCH] recordmcount: Fix warning comparing pointer to 0

Fix the following coccicheck warning:

scripts/recordmcount.c:142:13-14: WARNING comparing pointer to 0.

Signed-off-by: KaiLong Wang <[email protected]>
---
scripts/recordmcount.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
index cce12e1971d8..750f5196608c 100644
--- a/scripts/recordmcount.c
+++ b/scripts/recordmcount.c
@@ -139,7 +139,7 @@ static ssize_t uwrite(void const *const buf, size_t const count)
static void * umalloc(size_t size)
{
void *const addr = malloc(size);
- if (addr == 0) {
+ if (addr) {
fprintf(stderr, "malloc failed: %zu bytes\n", size);
file_append_cleanup();
mmap_cleanup();
--
2.25.1

2022-11-06 16:46:42

by Christophe JAILLET

Subject: Re: [PATCH] recordmcount: Fix warning comparing pointer to 0

Le 06/11/2022 à 16:11, [email protected] a écrit :
> Fix the following coccicheck warning:
>
> scripts/recordmcount.c:142:13-14: WARNING comparing pointer to 0.
>
> Signed-off-by: KaiLong Wang <[email protected]>
> ---
> scripts/recordmcount.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index cce12e1971d8..750f5196608c 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -139,7 +139,7 @@ static ssize_t uwrite(void const *const buf, size_t const count)
> static void * umalloc(size_t size)
> {
> void *const addr = malloc(size);
> - if (addr == 0) {
> + if (addr) {

Hi,
this change looks incorrect.

if (!addr)

maybe?

CJ

> fprintf(stderr, "malloc failed: %zu bytes\n", size);
> file_append_cleanup();
> mmap_cleanup();