2022-12-22 12:15:29

by Miaoqian Lin

Subject: [PATCH] media: v4l2-ctrls: Fix doc for v4l2_ctrl_request_hdl_find

We should call v4l2_ctrl_request_hdl_put() instead of
v4l2_ctrl_request_put_hdl(). Fix the typo.

Signed-off-by: Miaoqian Lin <[email protected]>
---
include/media/v4l2-ctrls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
index e59d9a234631..7788eeb3e2bb 100644
--- a/include/media/v4l2-ctrls.h
+++ b/include/media/v4l2-ctrls.h
@@ -1343,7 +1343,7 @@ void v4l2_ctrl_request_complete(struct media_request *req,
* @parent: The parent control handler ('priv' in media_request_object_find())
*
* This function finds the control handler in the request. It may return
- * NULL if not found. When done, you must call v4l2_ctrl_request_put_hdl()
+ * NULL if not found. When done, you must call v4l2_ctrl_request_hdl_put()
* with the returned handler pointer.
*
* If the request is not in state VALIDATING or QUEUED, then this function
--
2.25.1

2022-12-22 15:03:52

by Nicolas Dufresne

Subject: Re: [PATCH] media: v4l2-ctrls: Fix doc for v4l2_ctrl_request_hdl_find

Le jeudi 22 décembre 2022 à 15:56 +0400, Miaoqian Lin a écrit :
> We should call v4l2_ctrl_request_hdl_put() instead of
> v4l2_ctrl_request_put_hdl(). Fix the typo.
>
> Signed-off-by: Miaoqian Lin <[email protected]>

Reviewed-by: Nicolas Dufresne <[email protected]>

> ---
> include/media/v4l2-ctrls.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index e59d9a234631..7788eeb3e2bb 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -1343,7 +1343,7 @@ void v4l2_ctrl_request_complete(struct media_request *req,
> * @parent: The parent control handler ('priv' in media_request_object_find())
> *
> * This function finds the control handler in the request. It may return
> - * NULL if not found. When done, you must call v4l2_ctrl_request_put_hdl()
> + * NULL if not found. When done, you must call v4l2_ctrl_request_hdl_put()
> * with the returned handler pointer.
> *
> * If the request is not in state VALIDATING or QUEUED, then this function