2006-03-04 16:07:56

by Adrian Bunk

[permalink] [raw]
Subject: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL

This option should IMHO no longer depend on EXPERIMENTAL.


Signed-off-by: Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 12 Feb 2006

--- linux-2.6.16-rc2-mm1-full/net/sched/Kconfig.old 2006-02-12 02:21:30.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/net/sched/Kconfig 2006-02-12 02:21:58.000000000 +0100
@@ -434,7 +434,6 @@

config NET_CLS_ACT
bool "Actions"
- depends on EXPERIMENTAL
select NET_ESTIMATOR
---help---
Say Y here if you want to use traffic control actions. Actions



2006-03-04 16:56:30

by Patrick McHardy

[permalink] [raw]
Subject: Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL

Adrian Bunk wrote:
> This option should IMHO no longer depend on EXPERIMENTAL.
>
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
>
> This patch was already sent on:
> - 12 Feb 2006

Yesterday I managed to crash my machine playing around with tc actions
within minutes. I haven't looked into it yet, but it seems it still
needs more testing.

2006-03-04 18:52:56

by jamal

[permalink] [raw]
Subject: Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL

On Sat, 2006-04-03 at 17:56 +0100, Patrick McHardy wrote:
> Adrian Bunk wrote:
> > This option should IMHO no longer depend on EXPERIMENTAL.
> >
> >
> > Signed-off-by: Adrian Bunk <[email protected]>
> >
> > ---
> >
> > This patch was already sent on:
> > - 12 Feb 2006
>
> Yesterday I managed to crash my machine playing around with tc actions
> within minutes. I haven't looked into it yet, but it seems it still
> needs more testing.

Simple: Fix the bug and submit a patch. If you cant find the cause post
what you are doing.

What is the metric for going from experimental to non-experimental?
I surely hope it doesnt come to some irrational reasoning like
"Patrick found a bug"[1].
- It has been around since 2.6.7/8;
- I use it extensively on about 10 machines since (I am pretty sure a
lot more extensively than Patrick)
- I know people who use it extensively
- I am pretty sure there are people that i dont know who use it
extensively

So on Adrian's patch and above reasoning:

ACKed-by: Jamal Hadi Salim <[email protected]>

cheers,
jamal

[1]If you used half of that logic on netfilter it would still be
experimental or rather should be demoted to experimental.


2006-03-04 20:37:09

by Patrick McHardy

[permalink] [raw]
Subject: Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL

jamal wrote:
> On Sat, 2006-04-03 at 17:56 +0100, Patrick McHardy wrote:
>
>>Adrian Bunk wrote:
>>
>>>This option should IMHO no longer depend on EXPERIMENTAL.
>>>
>>
>>Yesterday I managed to crash my machine playing around with tc actions
>>within minutes. I haven't looked into it yet, but it seems it still
>>needs more testing.
>
>
> Simple: Fix the bug and submit a patch. If you cant find the cause post
> what you are doing.

I'll fix it.

> What is the metric for going from experimental to non-experimental?
> I surely hope it doesnt come to some irrational reasoning like
> "Patrick found a bug"[1].

I think a sane metric is "opinion of people who know the code". But
I don't care much, I don't think many people care whether something
is maked experimental or not.

> [1]If you used half of that logic on netfilter it would still be
> experimental or rather should be demoted to experimental.

I'll take that as a compliment :)

2006-03-10 11:04:25

by David Miller

[permalink] [raw]
Subject: Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL

From: jamal <[email protected]>
Date: Sat, 04 Mar 2006 13:52:21 -0500

> So on Adrian's patch and above reasoning:
>
> ACKed-by: Jamal Hadi Salim <[email protected]>

Applied, thanks Adrian.