2006-12-12 10:37:24

by Nigel Cunningham

[permalink] [raw]
Subject: [PATCH] Fix swapped parameters in mm/vmscan.c.

The version of mm/vmscan.c in Linus' current tree has swapped parameters
in the shrink_all_zones declaration and call, used by the various
suspend-to-disk implementations. This doesn't seem to have any great
adverse effect, but it's clearly wrong.

Signed-off-by: Nigel Cunningham <[email protected]>

diff -ruNp 930-vmscan.patch-old/mm/vmscan.c 930-vmscan.patch-new/mm/vmscan.c
--- 930-vmscan.patch-old/mm/vmscan.c 2006-12-12 12:24:05.000000000 +1100
+++ 930-vmscan.patch-new/mm/vmscan.c 2006-12-12 12:23:52.000000000 +1100
@@ -1443,8 +1443,8 @@ void wakeup_kswapd(struct zone *zone, in
*
* For pass > 3 we also try to shrink the LRU lists that contain a few pages
*/
-static unsigned long shrink_all_zones(unsigned long nr_pages, int pass,
- int prio, struct scan_control *sc)
+static unsigned long shrink_all_zones(unsigned long nr_pages, int prio,
+ int pass, struct scan_control *sc)
{
struct zone *zone;
unsigned long nr_to_scan, ret = 0;